[issue41692] Deprecate immortal interned strings: PyUnicode_InternImmortal()

STINNER Victor added the comment: I cannot find "PyUnicode_InternImmortal" pattern in the source code of the PyPI top 5000 projects (December 1, 2021). I only found a false positive in frozendict-2.1.1: frozendict/src/3_10/cpython_src/Include/unicodeobject.h: // PyUnicode_InternImmortal()

[issue41692] Deprecate immortal interned strings: PyUnicode_InternImmortal()

Inada Naoki added the comment: For the record, I noticed PyUnicode_InternImmortal() is a stable ABI. We may need to keep the function to avoid dynamic link errors. But we can still change its implementation to just raise an exception. -- ___

[issue41692] Deprecate immortal interned strings: PyUnicode_InternImmortal()

STINNER Victor added the comment: The function is now deprecated. Thanks for the review INADA-san, I close the issue. Let's meet in Python 3.12 to remove it ;-) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___

[issue41692] Deprecate immortal interned strings: PyUnicode_InternImmortal()

STINNER Victor added the comment: New changeset 583ee5a5b1971a18ebeb877948ce6264da0cc8aa by Victor Stinner in branch 'master': bpo-41692: Deprecate PyUnicode_InternImmortal() (GH-22486) https://github.com/python/cpython/commit/583ee5a5b1971a18ebeb877948ce6264da0cc8aa --

[issue41692] Deprecate immortal interned strings: PyUnicode_InternImmortal()

STINNER Victor added the comment: I proposed PR 22486 to deprecate the function. -- ___ Python tracker ___ ___ Python-bugs-list

[issue41692] Deprecate immortal interned strings: PyUnicode_InternImmortal()

Change by STINNER Victor : -- keywords: +patch pull_requests: +21503 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22486 ___ Python tracker ___

[issue41692] Deprecate immortal interned strings: PyUnicode_InternImmortal()

hai shi added the comment: +1 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41692] Deprecate immortal interned strings: PyUnicode_InternImmortal()

Dong-hee Na added the comment: +1 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41692] Deprecate immortal interned strings: PyUnicode_InternImmortal()

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41692] Deprecate immortal interned strings: PyUnicode_InternImmortal()

Inada Naoki added the comment: +1 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41692] Deprecate immortal interned strings: PyUnicode_InternImmortal()

Change by hai shi : -- nosy: +shihai1991 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41692] Deprecate immortal interned strings: PyUnicode_InternImmortal()

New submission from STINNER Victor : Python has the concept of "immortal" interned strings: PyUnicode_InternImmortal(). The feature was first introduced in the Python 2 "str" (bytes) type, bpo-576101 (commit 45ec02aed14685c353e55841b5acbc0dadee76f8). New PyString_InternImmortal() function.