[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: > bpo-41713: Port _signal module to multi-phase init (GH-23355) This change caused a regression: bpo-43963. -- ___ Python tracker ___ __

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: New changeset e8e66eab941b983b6e85cd0d57cd45838880c568 by Victor Stinner in branch 'master': bpo-41713: Remove PyOS_InitInterrupts() from python3dll.c (GH-24257) https://github.com/python/cpython/commit/e8e66eab941b983b6e85cd0d57cd45838880c568 -- _

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: Petr Viktorin: > The PyOS_InitInterrupts function is still listed in PC/python3dll.c. Ooops, I proposed PR 24257 to remove it. -- ___ Python tracker ___

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

Change by STINNER Victor : -- pull_requests: +23079 pull_request: https://github.com/python/cpython/pull/24257 ___ Python tracker ___ __

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

Petr Viktorin added the comment: The PyOS_InitInterrupts function is still listed in PC/python3dll.c. -- nosy: +petr.viktorin ___ Python tracker ___ __

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: Done! _signal uses again the multi-phase init API. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: New changeset 7f9b25a21ab95f8cf8d663396993766307be475c by Victor Stinner in branch 'master': bpo-41713: Port _signal module to multi-phase init (GH-23355) https://github.com/python/cpython/commit/7f9b25a21ab95f8cf8d663396993766307be475c --

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

Change by STINNER Victor : -- pull_requests: +22248 pull_request: https://github.com/python/cpython/pull/23355 ___ Python tracker ___ __

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: New changeset 29aa624047f893b3b3194f00252b2156bbbf4f9b by Victor Stinner in branch 'master': bpo-41686: Move _Py_RestoreSignals() to signalmodule.c (GH-23353) https://github.com/python/cpython/commit/29aa624047f893b3b3194f00252b2156bbbf4f9b -- __

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: New changeset a702bd4b921167e73f8fc987aa64ada571fdc3f8 by Victor Stinner in branch '3.8': bpo-41686: Always create the SIGINT event on Windows (GH-23344) (GH-23347) (GH-23349) https://github.com/python/cpython/commit/a702bd4b921167e73f8fc987aa64ada571fdc3f8

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

Change by STINNER Victor : -- pull_requests: +22243 pull_request: https://github.com/python/cpython/pull/23349 ___ Python tracker ___ __

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: New changeset 05a5d697f4f097f37c5c1e2ed0e2338a33c3fb6a by Victor Stinner in branch '3.9': bpo-41686: Always create the SIGINT event on Windows (GH-23344) (GH-23347) https://github.com/python/cpython/commit/05a5d697f4f097f37c5c1e2ed0e2338a33c3fb6a --

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

Change by STINNER Victor : -- pull_requests: +22240 pull_request: https://github.com/python/cpython/pull/23347 ___ Python tracker ___ __

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: New changeset 0ae323b87f1bed64a7fa70f5a41a5800aca032cc by Victor Stinner in branch 'master': bpo-41686: Always create the SIGINT event on Windows (GH-23344) https://github.com/python/cpython/commit/0ae323b87f1bed64a7fa70f5a41a5800aca032cc -- __

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

Change by STINNER Victor : -- pull_requests: +22236 pull_request: https://github.com/python/cpython/pull/23344 ___ Python tracker ___ __

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: New changeset 296a796951032f678d063008f588ccc6958d0df1 by Victor Stinner in branch 'master': bpo-41713: Remove PyOS_InitInterrupts() function (GH-23342) https://github.com/python/cpython/commit/296a796951032f678d063008f588ccc6958d0df1 -- __

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

Change by STINNER Victor : -- pull_requests: +22233 pull_request: https://github.com/python/cpython/pull/23342 ___ Python tracker ___ __

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

Change by STINNER Victor : -- pull_requests: +22209 pull_request: https://github.com/python/cpython/pull/23318 ___ Python tracker ___ __

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: See also: * bpo-40600: "Add an option to disallow creating more than one instance of a module". * bpo-40288: [subinterpreters] atexit module should not be loaded more than once per interpreter -- ___ Python track

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

mohamed koubaa added the comment: Sounds like there needs to be some python-wide global state that perhaps the signal module wraps rather than owns. I could try to prototype it if you agree -- nosy: +koubaa ___ Python tracker

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

Change by hai shi : -- nosy: +shihai1991 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: New changeset 4b8032e5a4994a7902076efa72fca1e2c85d8b7f by Victor Stinner in branch 'master': bpo-41713: _signal doesn't use multi-phase init (GH-22087) https://github.com/python/cpython/commit/4b8032e5a4994a7902076efa72fca1e2c85d8b7f -- ___

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

Change by STINNER Victor : -- keywords: +patch pull_requests: +21173 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22087 ___ Python tracker ___ _

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: Another problem: PyOS_FiniInterrupts() is a public function of the C API which access global variables like IntHandler, DefaultHandler and IgnoreHandler. -- ___ Python tracker

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: About the leak, the following three variables are also initialized multiple times by signal_exec(): static PyObject *DefaultHandler; static PyObject *IgnoreHandler; static PyObject *IntHandler; -- ___ Python track

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

STINNER Victor added the comment: The signal module is really special. In Python, only the main thread of the main interpreter is supposed to be allowed to run Python signal handlers (but the C signal handler can be executed by any thread). The exec function of the _signal module runs action

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

Change by STINNER Victor : -- title: test_interpreters leaked [1424, 1422, 1424] references -> _signal module leak: test_interpreters leaked [1424, 1422, 1424] references ___ Python tracker _