[issue42085] Add dedicated slot for sending values

Pablo Galindo Salgado added the comment: Oh, my bad. I can't find the enum values of the return type, though (PySendResult). -- ___ Python tracker ___

[issue42085] Add dedicated slot for sending values

Dennis Sweeney added the comment: It did get added to the correct docs: https://docs.python.org/3.10/c-api/typeobj.html#c.PyAsyncMethods.am_send (the 3.10 and 3.11 docs, not the 3.9 docs ;-) But as I mentioned, I feel that there could be more details about the semantics/contract.

[issue42085] Add dedicated slot for sending values

Pablo Galindo Salgado added the comment: I am reopening this issue since am_send never got documented here: https://docs.python.org/3/c-api/typeobj.html#async-structs -- nosy: +pablogsal resolution: fixed -> status: closed -> open ___ Python

[issue42085] Add dedicated slot for sending values

Dennis Sweeney added the comment: Is there documentation anywhere for the semantics of am_send? I only see the signature followed by "See PyIter_Send for details", but the doc for PyIter_Send doesn't mention am_send. In particular, it would be nice to document the relationship between

[issue42085] Add dedicated slot for sending values

Petr Viktorin added the comment: Py_TPFLAGS_HAVE_AM_SEND is unnecessary and I'd like to remove it. It is not possible for type objects to have a different layout than the interpreter: - extensions using the regular ABI must be recompiled for each feature version of Python - extensions using

[issue42085] Add dedicated slot for sending values

Irit Katriel added the comment: New changeset d338ce0796e5fe8e54dfe52f93ed9d5936ad3efe by Miss Islington (bot) in branch '3.10': bpo-42085: [docs] Add versionadded for am_send in type object documentation (GH-25465) (GH-26453)

[issue42085] Add dedicated slot for sending values

Change by miss-islington : -- pull_requests: +25049 pull_request: https://github.com/python/cpython/pull/26453 ___ Python tracker ___

[issue42085] Add dedicated slot for sending values

Irit Katriel added the comment: New changeset 0b11c429c7f1721d9ffb9ae19e3e8e2e7bd6444d by Martmists in branch 'main': bpo-42085: [docs] Add versionadded for am_send in type object documentation (GH-25465) https://github.com/python/cpython/commit/0b11c429c7f1721d9ffb9ae19e3e8e2e7bd6444d

[issue42085] Add dedicated slot for sending values

Change by Martmists : -- nosy: +martmists nosy_count: 4.0 -> 5.0 pull_requests: +25048 pull_request: https://github.com/python/cpython/pull/25465 ___ Python tracker ___

[issue42085] Add dedicated slot for sending values

Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue42085] Add dedicated slot for sending values

Yury Selivanov added the comment: > Is anything left to do? I think we can close this now. -- ___ Python tracker ___ ___

[issue42085] Add dedicated slot for sending values

Andrew Svetlov added the comment: Is anything left to do? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42085] Add dedicated slot for sending values

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42085] Add dedicated slot for sending values

miss-islington added the comment: New changeset 7c9487ded487f304c2906698c52f0815b92cbeb6 by Vladimir Matveev in branch 'master': bpo-42085: Add documentation for Py_TPFLAGS_HAVE_AM_SEND (GH-23374) https://github.com/python/cpython/commit/7c9487ded487f304c2906698c52f0815b92cbeb6 --

[issue42085] Add dedicated slot for sending values

Change by Vladimir Matveev : -- pull_requests: +22267 pull_request: https://github.com/python/cpython/pull/23374 ___ Python tracker ___

[issue42085] Add dedicated slot for sending values

Andrew Svetlov added the comment: Thank you Victor for the report! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue42085] Add dedicated slot for sending values

STINNER Victor added the comment: commit cda99b4022daa08ac74b0420e9903cce883d91c6 (HEAD -> master, upstream/master) Author: Andrew Svetlov Date: Wed Nov 11 17:48:53 2020 +0200 Fix memory leak introduced by GH-22780 (GH-23237) -- ___ Python

[issue42085] Add dedicated slot for sending values

STINNER Victor added the comment: Thanks! The change fixed the leak: $ ./python -m test -j0 -R 3:3 test_asyncgen test_coroutines test_unittest # test_asyncio (...) Tests result: SUCCESS I didn't run test_asyncio because the test is too slow. --

[issue42085] Add dedicated slot for sending values

Andrew Svetlov added the comment: PR for the fix is created: https://github.com/python/cpython/pull/23237 -- ___ Python tracker ___

[issue42085] Add dedicated slot for sending values

Change by Andrew Svetlov : -- pull_requests: +22135 pull_request: https://github.com/python/cpython/pull/23237 ___ Python tracker ___

[issue42085] Add dedicated slot for sending values

Andrew Svetlov added the comment: Investigating. The test leaks a future instance. -- ___ Python tracker ___ ___ Python-bugs-list

[issue42085] Add dedicated slot for sending values

STINNER Victor added the comment: > New changeset 1e996c3a3b51e9c6f1f4cea8a6dbcf3bcb865060 by Vladimir Matveev in > branch 'master': This change introduced big reference leaks: 4 tests failed: test_asyncgen test_asyncio test_coroutines test_unittest Example: $ ./python -m test

[issue42085] Add dedicated slot for sending values

Yury Selivanov added the comment: New changeset 1e996c3a3b51e9c6f1f4cea8a6dbcf3bcb865060 by Vladimir Matveev in branch 'master': bpo-42085: Introduce dedicated entry in PyAsyncMethods for sending values (#22780)

[issue42085] Add dedicated slot for sending values

Yury Selivanov added the comment: Vladimir, please do a follow up PR documenting Py_TPFLAGS_HAVE_AM_SEND. -- ___ Python tracker ___

[issue42085] Add dedicated slot for sending values

Change by Terry J. Reedy : -- nosy: +asvetlov, yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42085] Add dedicated slot for sending values

Change by Vladimir Matveev : -- type: -> performance ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42085] Add dedicated slot for sending values

Change by Vladimir Matveev : -- keywords: +patch pull_requests: +21739 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22780 ___ Python tracker

[issue42085] Add dedicated slot for sending values

New submission from Vladimir Matveev : https://bugs.python.org/issue41756 has introduced PyIter_Send as a common entrypoint for sending values however currently fast path that does not use StopIteration exception is only available for generators/coroutines. It would be quite nice if this