[issue42120] Depreciated MACRO of copysign for MSVC

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue42120] Depreciated MACRO of copysign for MSVC

miss-islington added the comment: New changeset 2c38e49dba88a39679b2182ca3f5f478d3a3f647 by Miss Islington (bot) in branch '3.9': [3.9] bpo-42120: Remove macro defining copysign to _copysign on Windows (GH-23326) (GH-23331)

[issue42120] Depreciated MACRO of copysign for MSVC

miss-islington added the comment: New changeset 4f54ca07341c656b763c8c71a051f7f86a2a256c by Miss Islington (bot) in branch '3.8': bpo-42120: Remove macro defining copysign to _copysign on Windows (GH-23326) https://github.com/python/cpython/commit/4f54ca07341c656b763c8c71a051f7f86a2a256c

[issue42120] Depreciated MACRO of copysign for MSVC

Change by miss-islington : -- pull_requests: +22219 pull_request: https://github.com/python/cpython/pull/23331 ___ Python tracker ___

[issue42120] Depreciated MACRO of copysign for MSVC

Steve Dower added the comment: New changeset 9cc9e277254023c0ca08e1a9e379fd89475ca9c2 by Steve Dower in branch 'master': bpo-42120: Remove macro defining copysign to _copysign on Windows (GH-23326) https://github.com/python/cpython/commit/9cc9e277254023c0ca08e1a9e379fd89475ca9c2 --

[issue42120] Depreciated MACRO of copysign for MSVC

Change by miss-islington : -- nosy: +miss-islington nosy_count: 6.0 -> 7.0 pull_requests: +22218 pull_request: https://github.com/python/cpython/pull/23330 ___ Python tracker

[issue42120] Depreciated MACRO of copysign for MSVC

Steve Dower added the comment: Turns out a straight delete is fine, as both names are defined in UCRT. I think it's safe to backport as well, since it's only going to affect other people's code poorly (and they'll need to recompile to see any change anyway). -- assignee: ->

[issue42120] Depreciated MACRO of copysign for MSVC

Change by Steve Dower : -- keywords: +patch pull_requests: +22216 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23326 ___ Python tracker ___

[issue42120] Depreciated MACRO of copysign for MSVC

Ronald Oussoren added the comment: The standard is for copysign to work on doubles, with copysignf as the same functionality for floats. https://en.cppreference.com/w/c/numeric/math/copysign -- nosy: +ronaldoussoren ___ Python tracker

[issue42120] Depreciated MACRO of copysign for MSVC

Steve Dower added the comment: Sounds good, but I don't think we can backport it. It's not _our_ public API, but it's still going to impact compiling modules. Also, looking at the docs link above, copysign() is for floats and _copysign() is for doubles, which means it's an actual functional

[issue42120] Depreciated MACRO of copysign for MSVC

Change by Zachary Ware : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___ ___

[issue42120] Depreciated MACRO of copysign for MSVC

Change by Erjia Guan : -- versions: +Python 3.10, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42120] Depreciated MACRO of copysign for MSVC

New submission from Erjia Guan : At https://github.com/python/cpython/blob/c60394c7fc9cc09b16e9675a3eeb5844b6d8523f/PC/pyconfig.h#L196, the MACRO converts copysign to _copysign. This MACRO is defined 13 years ago and it's really dangerous to define a lower-letter MACRO at this low level.