[issue42129] Support resources in namespace packages

STINNER Victor added the comment: > Please see bpo-43569: "test_importlib failed on installed Python" regression > introduced by commit 67148254146948041a77d8a2989f41b88cdb2f99. It's now fixed, I close again this issue. -- resolution: -> fixed status: open -> closed

[issue42129] Support resources in namespace packages

STINNER Victor added the comment: I reopen the issue. -- resolution: fixed -> status: closed -> open ___ Python tracker ___ ___

[issue42129] Support resources in namespace packages

STINNER Victor added the comment: Please see bpo-43569: "test_importlib failed on installed Python" regression introduced by commit 67148254146948041a77d8a2989f41b88cdb2f99. -- nosy: +vstinner ___ Python tracker

[issue42129] Support resources in namespace packages

Change by Jason R. Coombs : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue42129] Support resources in namespace packages

Jason R. Coombs added the comment: New changeset 67148254146948041a77d8a2989f41b88cdb2f99 by Jason R. Coombs in branch 'master': bpo-42129: Add support for resources in namespaces (GH-24670) https://github.com/python/cpython/commit/67148254146948041a77d8a2989f41b88cdb2f99 --

[issue42129] Support resources in namespace packages

Change by Jason R. Coombs : -- keywords: +patch pull_requests: +23456 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24670 ___ Python tracker ___

[issue42129] Support resources in namespace packages

Jason R. Coombs added the comment: I've pushed [this branch](https://github.com/python/cpython/tree/feature/42129-resources-namespace-packages), which includes fixes for the above two identified issues. Still one issue remains: ERROR: test_package_has_no_reader_fallback

[issue42129] Support resources in namespace packages

Jason R. Coombs added the comment: > I would harmonize towards what the concrete implementations... For FileReader and ZipReader, both rely on TraversableResources to implement contents, which rely on `files().iterdir()`, which could raise FileNotFoundError and definitely don't return

[issue42129] Support resources in namespace packages

Brett Cannon added the comment: I would harmonize towards what the concrete implementations are doing since people who don't implement the defaults will get the appropriate results regardless. An entry in What's New will cover any potential notification of the change since you can't exactly

[issue42129] Support resources in namespace packages

Jason R. Coombs added the comment: For the first two errors, the issue seems to be that CPython includes tests for the ResourceReader ABC and asserts that .contents() returns an empty list as the default degenerate behavior

[issue42129] Support resources in namespace packages

Jason R. Coombs added the comment: Thanks! No rush, but ideally soon enough to be merged before the beta release of Python 3.10 (2021-05-03). -- ___ Python tracker ___

[issue42129] Support resources in namespace packages

Filipe Laíns added the comment: Yes, I will look into it. Do we have a time schedule for when this should be ready, so that I can organize myself? -- ___ Python tracker ___

[issue42129] Support resources in namespace packages

Jason R. Coombs added the comment: In [this commit](https://github.com/python/importlib_resources/commit/bd20d893f11f387d285c666bc99fd2d4a7c33ef8), I've reconciled and merged the changes from importlib_resources 3.2-5.0, mainly the namespace package support

[issue42129] Support resources in namespace packages

Change by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42129] Support resources in namespace packages

Change by Filipe Laíns : -- nosy: +FFY00 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42129] Support resources in namespace packages

New submission from Jason R. Coombs : In [importlib_resources#68](https://github.com/python/importlib_resources/issues/68), the project identified a deficiency with respect to pkg_resources for resources in namespace packages. The project has since merged support for these packages, slated