[issue42151] Pure Python xml.etree.ElementTree is missing default attribute values

Dong-hee Na added the comment: @obfusk Thank you Felix for reporting and contributing! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.9 ___ Python tracker

[issue42151] Pure Python xml.etree.ElementTree is missing default attribute values

Dong-hee Na added the comment: New changeset 1f433406bd46fbd00b88223ad64daea6bc9eaadc by Felix C. Stegerman in branch 'master': bpo-42151: don't set specified_attributes=1 in pure Python ElementTree (GH-22987) https://github.com/python/cpython/commit/1f433406bd46fbd00b88223ad64daea6bc9eaadc

[issue42151] Pure Python xml.etree.ElementTree is missing default attribute values

mattip added the comment: PyPy issue https://foss.heptapod.net/pypy/pypy/-/issues/3181 shows another problem with the pure-python ElementTree implementation, that again is not reflected in the C implementation. Is there a code owner for this stdlib module? --

[issue42151] Pure Python xml.etree.ElementTree is missing default attribute values

Raymond Hettinger added the comment: > Changing the behaviour of the C implementation would > certainly break a lot more code than changing the Python > implementation. +1 for changing only the Python implementation. -- nosy: +rhettinger ___

[issue42151] Pure Python xml.etree.ElementTree is missing default attribute values

mattip added the comment: Is there an owner for the XML module that can make a decision? The PR has a test that shows this fix brings the python implementation into sync with the C implementation, which is, unintuitively, the "reference implementation". -- nosy: +mattip

[issue42151] Pure Python xml.etree.ElementTree is missing default attribute values

Stefan Behnel added the comment: In general, since the C accelerator is enabled by default, and few people would consider disabling it explicitly, I generally consider the behaviour of the C implementation to be "right", if both implementations differ. As a single data point, the reason why

[issue42151] Pure Python xml.etree.ElementTree is missing default attribute values

Felix C. Stegerman added the comment: > specified_attributes = True is also set in xml.dom.expatbuilder. That's good to know and should perhaps be addressed as well. > Should not it be set to true in the C implementation of ElementTree? That would break existing code. Including mine. I

[issue42151] Pure Python xml.etree.ElementTree is missing default attribute values

Serhiy Storchaka added the comment: specified_attributes = True is also set in xml.dom.expatbuilder. Should not it be set to true in the C implementation of ElementTree? -- ___ Python tracker

[issue42151] Pure Python xml.etree.ElementTree is missing default attribute values

Stefan Behnel added the comment: The patch looks right. I'm not sure if this can still be changed in Py3.8, though, since that has been around for quite a while now. Admittedly, few people will disable the C accelerator module and thus whitness this issue, but for them, this is a breaking

[issue42151] Pure Python xml.etree.ElementTree is missing default attribute values

Change by Felix C. Stegerman : -- keywords: +patch pull_requests: +21901 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22987 ___ Python tracker

[issue42151] Pure Python xml.etree.ElementTree is missing default attribute values

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42151] Pure Python xml.etree.ElementTree is missing default attribute values

Change by Karthikeyan Singaravelan : -- nosy: +eli.bendersky, scoder, serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list

[issue42151] Pure Python xml.etree.ElementTree is missing default attribute values

New submission from Felix C. Stegerman : I originally reported this as a bug in PyPy, but it turns out that CPython's C implementation (_elementtree) behaves differently than the pure Python version (b/c it sets specified_attributes = 1). PyPy issue with example code: