[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: One true positive today: https://github.com/python/cpython/pull/32355 -- ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: New changeset d0e696e05d4aaca1f1cde72a5c3326ca3d0f5c24 by Julien Palard in branch 'main': bpo-42238: [doc]: A make sucpicious false positive. (GH-32329) https://github.com/python/cpython/commit/d0e696e05d4aaca1f1cde72a5c3326ca3d0f5c24 --

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +30388 pull_request: https://github.com/python/cpython/pull/32329 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: New changeset bdc497496548e30fa208a8d98c30bf6d1833ac4c by Julien Palard in branch 'main': bpo-42238: [doc]: make suspicious: false positive. (GH-32292) https://github.com/python/cpython/commit/bdc497496548e30fa208a8d98c30bf6d1833ac4c --

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: One true positive and one false positive this week, see: - 7f9c084fdec7ddcfe8855aa79f98545591ae2261 - ec8906fb5930b1f078e2a2170cdf445e6c6faf57 -- ___ Python tracker

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +30354 pull_request: https://github.com/python/cpython/pull/32292 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: New changeset ec8906fb5930b1f078e2a2170cdf445e6c6faf57 by Julien Palard in branch 'main': bpo-42238: [doc] Some lines moved in rst, but had hardcoded lineno in susp-ignored.csv. (GH-32070)

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +30159 pull_request: https://github.com/python/cpython/pull/32070 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +30067 pull_request: https://github.com/python/cpython/pull/31977 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: News: Hitting 3 months without a true positive from `make suspicious`, looks like sphinxlint starting to take over properly, I hope to close this issue soon (like in a few months maybe). Also sphinxlint attracted some contributors [1] \o/ [1]

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: New changeset b878b3af0b3a9e3ab3ffcaf90a4066dfb3bb7cac by Julien Palard in branch 'main': bpo-42238: [doc] moving from rstlint.py to sphinx-lint. (GH-31097) https://github.com/python/cpython/commit/b878b3af0b3a9e3ab3ffcaf90a4066dfb3bb7cac --

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +29282 pull_request: https://github.com/python/cpython/pull/31097 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

STINNER Victor added the comment: > https://pypi.org/project/sphinx-lint/ Congrats :-) -- ___ Python tracker ___ ___

[issue42238] Deprecate suspicious.py?

Georg Brandl added the comment: Looks good. I should have rights automatically for everything in that org. -- ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: Georg, I was able to move forward: - https://github.com/sphinx-contrib/sphinx-lint - https://pypi.org/project/sphinx-lint/ Does everything looks good to you? Next step would be to remove rstlint.py from Docs/tools and add a dependency to rstlint from the

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: OK, we have: https://github.com/sphinx-contrib/sphinx-lint Ping me if you want rights :) -- ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Georg Brandl added the comment: Sure! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: > You gave me a small shock, but I checked and it was only 11/12 years ago :D HAha! Either I misstyped 12 as 21, either I'm bad at math, sorry for the shock ;) > I'm fine with moving this out of tree; please coordinate with the Sphinx > maintainers whether

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: New changeset 44afdbd5af4503e376148e9404b9c7a4f595b1fe by Julien Palard in branch 'main': bpo-42238: [doc] Avoid hardcoding fast-moving lines in susp-ignored.csv. (GH-30981) https://github.com/python/cpython/commit/44afdbd5af4503e376148e9404b9c7a4f595b1fe

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +29160 pull_request: https://github.com/python/cpython/pull/30981 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

STINNER Victor added the comment: > It currently looks like this: https://github.com/JulienPalard/sphinxlint but > should obviously be moved to github.com/python/ if we adopt this direction. If you want to move the project under the https://github.com/psf/ organization, the PSF has some

[issue42238] Deprecate suspicious.py?

STINNER Victor added the comment: IMO moving this small script into the separated project https://github.com/JulienPalard/sphinxlint will help people who are not core developers to contribute and it makes the tool usable by projects outside CPython. So yeah, it's a good thing! Also, it's

[issue42238] Deprecate suspicious.py?

Georg Brandl added the comment: > I was not here 21 years ago when it was introduced You gave me a small shock, but I checked and it was only 11/12 years ago :D I'm fine with moving this out of tree; please coordinate with the Sphinx maintainers whether it should be an "official" extension

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: I slowly started to work on rstlint in its own tree because working in a single file felt inconfortable. The more I advanced in this direction the more it made sense to me: - I first added tests, I may have been able to do so in the cpython tree though. - It

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +29059 pull_request: https://github.com/python/cpython/pull/30879 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: Another true positive for make suspicious: WARNING: [c-api/apiabiversion:70] ":macro" found in "the same format as the c:macro:" I'm working on implementing it on rstlint, in the meantime I opened: => https://github.com/python/cpython/pull/30149 to fix

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: A new false positive in b48ac6fe38b2fca9963b097c04cdecfc6083104e: +++ b/Misc/NEWS.d/next/Tests/2021-11-23-12-36-21.bpo-45878.eOs_Mp.rst @@ -0,0 +1,2 @@ +Test ``Lib/ctypes/test/test_functions.py::test_mro`` now uses +``self.assertRaises``

[issue42238] Deprecate suspicious.py?

Carol Willing added the comment: New changeset 024209401ebc8a011f242af00efdd8ecece6953d by Julien Palard in branch 'main': bpo-42238: [doc] Announce the future removal of make suspicous. (GH-29652) https://github.com/python/cpython/commit/024209401ebc8a011f242af00efdd8ecece6953d --

[issue42238] Deprecate suspicious.py?

Change by Alex Waygood : -- nosy: +AlexWaygood ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: /!\ rstlint did triggered some false positive: https://github.com/python/cpython/pull/29389/commits/f8ea20a0b51711b1c352c4aa4663cb953e7ebdc8 -- ___ Python tracker

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +27893 pull_request: https://github.com/python/cpython/pull/29652 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Łukasz Langa added the comment: New changeset d32316a2aacc3b3c4f6f56f96edb09a4437c8bdb by Julien Palard in branch 'main': bpo-42238: [doc]: Hide false positive in make suspicious. (GH-29636) https://github.com/python/cpython/commit/d32316a2aacc3b3c4f6f56f96edb09a4437c8bdb --

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +27867 pull_request: https://github.com/python/cpython/pull/29636 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: A new false positive today from 31b3a70edb1216bdc8fab3b2eafd8ddb00487f41: https://docs.python.org/dev/reference/datamodel.html#class-getitem-versus-getitem in: should be called:: from inspect import isclass def subscribe(obj, x):

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: DING DING DING DING DING DING, a new one today, and a true positive for `make suspicious`, fixed in: https://github.com/python/cpython/pull/28988/files (along with the test added to rstlint) -- ___ Python tracker

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: New suspicious today: [library/typing:1011] "`" found in "# Type of ``val`` is narrowed to ``list[str]``." But it's only because the old one with List[str] instead of list[str] was in susp-ignored.csv, so I just fixed susp-ignored.csv in

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +27143 pull_request: https://github.com/python/cpython/pull/28827 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: New changeset 37272f5800ee1e9fcb2da4a1766366519b9b3d94 by Julien Palard in branch 'main': bpo-42238: [doc] remove unused, and deduplicate, suspicious ignore rules. (GH-28137) https://github.com/python/cpython/commit/37272f5800ee1e9fcb2da4a1766366519b9b3d94

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +26576 pull_request: https://github.com/python/cpython/pull/28137 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: New changeset 21fa8547921d28b80b8a88d034081cab000d5480 by Julien Palard in branch 'main': bpo-42238: [doc] Some more make suspicious false positives. (GH-27945) https://github.com/python/cpython/commit/21fa8547921d28b80b8a88d034081cab000d5480 --

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: 10 false positives today, see: https://github.com/python/cpython/pull/27945/files I think I now need to put a deadline on this issue, let's say: one year without true positives and I drop it, so 2021-07-19 for now. (In the meantime, I continue to convert

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +26391 pull_request: https://github.com/python/cpython/pull/27945 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Łukasz Langa added the comment: New changeset fbf10080bb369cfef1f230c2cd5135a558b242d5 by Julien Palard in branch 'main': bpo-42238: Fix small rst issue in NEWS.d/. (#27238) https://github.com/python/cpython/commit/fbf10080bb369cfef1f230c2cd5135a558b242d5 -- nosy: +lukasz.langa

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: Another one \o/ Fix in: https://github.com/python/cpython/pull/27238 It is: :func:pdb.main Detected by make suspicious as: WARNING: [whatsnew/changelog:320] ":func" found in ": Refactor argument processing in :func:pdb.main to simplify"

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +25787 pull_request: https://github.com/python/cpython/pull/27238 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: New changeset 01331f1a3cf86fd308e9a134bb867bf01fb191f5 by Julien Palard in branch 'main': bpo-42238: rstlint: Add two new checks. (GH-26966) https://github.com/python/cpython/commit/01331f1a3cf86fd308e9a134bb867bf01fb191f5 --

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +25530 pull_request: https://github.com/python/cpython/pull/26966 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: Another true positive: ... versionchanged:: 3.11 from : 6cb145d23f5cf69b6d7414877d142747cd3d134c / https://github.com/python/cpython/pull/26820 I also think it can be implemented in rstlint. -- ___ Python

[issue42238] Deprecate suspicious.py?

Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: The previous one could probably be implemented in rstlint using (an equivalent of): git grep ':[a-z]\+:``[^:` ]+``' Doc/ Maybe specialized to known roles, like the script specializes to known directives. --

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: Spotted a true positive in b19f45533942e4ad7ddf9d2d94f8b87c6f746bce: :const:``None`` (I'm trying to build a true positive list, to have usefull cases where suspicious is usefull, so in the long term I can maybe implement those cases in rslint instead.)

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: New changeset 227a09325e7bf82ecd303b4696c054a086b29a00 by Julien Palard in branch 'main': bpo-42238: Doc CI: Disable suspicious checks. (GH-26575) https://github.com/python/cpython/commit/227a09325e7bf82ecd303b4696c054a086b29a00 --

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +25163 pull_request: https://github.com/python/cpython/pull/26575 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

STINNER Victor added the comment: At least, I would suggest to remove it from the release process. If some people working on the documentation want to keep the tool, maybe it can be an optional CI job? IMO the problem is that currently, it's part of a single "Documentation" job. I don't

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: I should have monitored this more closely, I started monitoring it weekly, then life got over until today when I'm even surprised to see activity on the issue, sry! (Surprise leading me to investigate why I had not received notifications from bpo, leading

[issue42238] Deprecate suspicious.py?

STINNER Victor added the comment: > Doc/tools/extensions/suspicious.py is a CPython specific extension, it's not > part of Sphinx. Maybe someone should open a feature request on Sphinx to get > a similar feature without false positives (or at least less false positives). This extension was

[issue42238] Deprecate suspicious.py?

STINNER Victor added the comment: I wrote a PR to enhance -W option documentation. The suspicious job complains whereas my Sphinx format is valid: The full form of argument is:: action:message:category:module:lineno Example of suspicious error: [using/cmdline:438] ":message"

[issue42238] Deprecate suspicious.py?

STINNER Victor added the comment: Julien Palard is working actively on the Python documentation. He is the one who removed suspicious "from the CI and docs builds". I trust his judgment here. I suggest to remove it again from there *and* from the release scripts. --

[issue42238] Deprecate suspicious.py?

Pablo Galindo Salgado added the comment: > Why did you catch them in the release process, and not in the regular Python > development workflow? Because our release tools run suspicious.py and it fails and then we need to manually inspect every single failure and fix it as almost all times

[issue42238] Deprecate suspicious.py?

STINNER Victor added the comment: Pablo: "I every single alpha release I had to fix actual documentation errors (no false positives)" I don't get it. Do you mean that the Python release process is blocked by typos in the documentation? Why did you catch them in the release process, and not

[issue42238] Deprecate suspicious.py?

Pablo Galindo Salgado added the comment: I agree with all you said, but I am against forcing the release management team to absorb the responsibility of fixing all the errors that the CI didn't catch, real or not. Releasing is already a multi-hour process and having many docs errors and

[issue42238] Deprecate suspicious.py?

Raymond Hettinger added the comment: If reactivated, the tool needs to be substantially improved. It is NOT smart. The false positives for slicing and logging examples are unnecessarily annoying. It creates a barrier for people submitting documentation patches. Each of the 367 entries

[issue42238] Deprecate suspicious.py?

Pablo Galindo Salgado added the comment: Background on why I reactivated it: I every single alpha release I had to fix actual documentation errors (no false positives) like the one fixed here: https://github.com/python/cpython/commit/20ac34772aa9805ccbf082e700f2b033291ff5d2 I don't like

[issue42238] Deprecate suspicious.py?

STINNER Victor added the comment: Pablo reenabled the check: commit 20ac34772aa9805ccbf082e700f2b033291ff5d2 (upstream/master, master) Author: Pablo Galindo Date: Mon Apr 12 20:53:15 2021 +0100 Fix Sphinx errors in the documentation and re-activate the suspicious check (GH-25368)

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: New changeset b9735420aa8ecd2555fe3dc000863bc50487334b by Julien Palard in branch 'master': bpo-42238: Check Misc/NEWS.d/next/ for reStructuredText issues. (GH-23802) https://github.com/python/cpython/commit/b9735420aa8ecd2555fe3dc000863bc50487334b

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: I created https://github.com/python/cpython/pull/23802 with a port of the "wrong backtick detector" (at least, one aspect from it) from suspicious to rstlint. I dropped the suspicious check three weeks ago, and found a single committed issue since then,

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- pull_requests: +22662 pull_request: https://github.com/python/cpython/pull/23802 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: Today I spotted one error that suspicious could have spotted: -both ``Callable``s no longer validate their ``argtypes``, in +both ``Callable``\ s no longer validate their ``argtypes``, in I'm fixing it in https://github.com/python/cpython/pull/23800

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: I'll try to track this closely, the drop of `make suspicious` has been merged in master, but not backported yet, one week ago. Up to today, no commit has introduced suspicious warnings (0 false positive, 0 false negative). I think I'll soon backport the PR,

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: New changeset c9c6e9f89aa68ce8094393a1a5575b67d26bc8c8 by Julien Palard in branch 'master': bpo-42238: Doc: Remove make suspicious from the CI and docs builds. (GH-23313) https://github.com/python/cpython/commit/c9c6e9f89aa68ce8094393a1a5575b67d26bc8c8

[issue42238] Deprecate suspicious.py?

Change by Julien Palard : -- keywords: +patch pull_requests: +22204 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23313 ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

Julien Palard added the comment: Good idea Ned! So proposed plan: - Drop it from docs build and the CI to avoid time loss. - Add it as a step of PEP 101, for a few release, for good measures - I'll check it from time to time between releases, just to ensure it does not accumulate tons of

[issue42238] Deprecate suspicious.py?

Ned Deily added the comment: If it still does useful checks, we could just limit it to running by release managers during the release manufacturing process; it is already run then. It would still allow for problems to be caught and fixed by the RM prior to release tagging. But I don't have

[issue42238] Deprecate suspicious.py?

Raymond Hettinger added the comment: I would love to see this disappear. For me, it has been a recurring time waster. -- nosy: +rhettinger ___ Python tracker ___

[issue42238] Deprecate suspicious.py?

New submission from Julien Palard : I was not here 21 years ago when it was introduced [1], but according to the commit message it was introduced to find leftover Latex mardown. It tries to find 4 patterns in Sphinx node text (not in raw rst files): ::(?=[^=])|# two :: (but NOT