[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

STINNER Victor added the comment: > test_nextafter fails on PPC64 AIX 3.x (build 749). It pass again in build 788, so I close the issue: https://buildbot.python.org/all/#/builders/438/builds/788 It would be great if the AIX libm could be fixed, but I wanted to fix the AIX buildbots, to be

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

STINNER Victor added the comment: New changeset 0837f99d3367ecf200033bbddfa05d061ae9f483 by Victor Stinner in branch 'master': bpo-42323: Fix math.nextafter() on AIX (GH-24381) https://github.com/python/cpython/commit/0837f99d3367ecf200033bbddfa05d061ae9f483 --

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

Change by STINNER Victor : -- pull_requests: +23198 pull_request: https://github.com/python/cpython/pull/24381 ___ Python tracker ___

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

STINNER Victor added the comment: Oh, it seems like Python no long builds on PPC64 AIX 3.x buildbot :-( https://bugs.python.org/issue42604#msg385347 -- ___ Python tracker ___

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

STINNER Victor added the comment: New changeset c1c3493fb7a3af8efdc50175e592d29e8cb93886 by Victor Stinner in branch 'master': bpo-42323: Fix math.nextafter() for NaN on AIX (GH-24265) https://github.com/python/cpython/commit/c1c3493fb7a3af8efdc50175e592d29e8cb93886 --

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

STINNER Victor added the comment: I wrote PR 24265 to fix the issue. math.nextafter(x, y) already had a special case for AIX for x==y. test_nextafter fails on PPC64 AIX 3.x (build 749). test_nextafter pass on POWER6 AIX 3.x (build 701). -- ___

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

Change by STINNER Victor : -- keywords: +patch pull_requests: +23090 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24265 ___ Python tracker ___

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

Michael Felt added the comment: While my patch in working - was successful in what it attempted to do, it did not fix this test issue. Instead - I reinstalled the `bos.adt.libm-7.2.0.0` fileset, to backout of the so-called bugfix/APAR IV95512. @David - can you take this up with AIX support

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

Michael Felt added the comment: I have been doing a lot of research on this. Wish I had thought do start the way I finished. Basically, when math.nextafter() was added all the AIX bots were on systems running AIX earlier than AIX 7.2 TL2. When AIX 7.2 TL2 was released (roughly Q3 2017) a

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

Mark Dickinson added the comment: [Victor] > How can we fix the buildbot? Add #ifdef in mathmodule.c to implement the > special cases, but only on AIX? Skip the test? I'm not super-keen on using #ifdefs to implement the special-case handling _just_ for AIX: that opens the door to a

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

STINNER Victor added the comment: > "./Modules/posixmodule.c", line 15146.53: 1506-045 (S) Undeclared identifier > SPLICE_F_MOVE. This is unrelated: https://bugs.python.org/issue41625#msg381259 Please continue the discussion this SPLICE there. --

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

Michael Felt added the comment: Yes, just probing, the version of gcc is irrelevant. What I do believe is important is that bot run 374, 375 and 376 passed - On AIX 7.1 TL4 SP8. The failure starting with 377 is an undefined variable. "./Modules/posixmodule.c", line 15146.53: 1506-045 (S)

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

David Edelsohn added the comment: I believe that Michael was trying to probe under what circumstances the failure appears. But, not GCC 4.7 is not relevant. -- ___ Python tracker

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

STINNER Victor added the comment: > Back to the bot: AIX 7.1 TL4 SP8 and gcc-4.7.4 The latest GCC version is GCC 10. Is it still relevant to test GCC 4.7 released 8 years ago? (Well, I'm not sure that the C compiler explains all issues.) -- ___

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

Michael Felt added the comment: There seems to be a lot of interaction of OS level and compiler used. * Waiting for the next bot run to get a different compiler. +++ AIX 6.1.6 and older libraries - no test errors reported AIX 7.1.4 and newer libraries - when using the binary built on 6.1.6

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

STINNER Victor added the comment: How can we fix the buildbot? Add #ifdef in mathmodule.c to implement the special cases, but only on AIX? Skip the test? -- ___ Python tracker

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

STINNER Victor added the comment: > The earlier problem was the handling of -0.0. At the time, the code was > hand-written assembly language that did not check for IEEE floating point > corner cases. I'm quite happy that my hand written tests detect bugs in nextafter() implementations ;-)

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

David Edelsohn added the comment: I investigated another problem with nextafter() in 2015 and opened an internal IBM AIX PMR. At the time it was not using decimal float code. The earlier problem was the handling of -0.0. At the time, the code was hand-written assembly language that did

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

Michael Felt added the comment: I have been experimenting with different hardware and AIX versions. When building on AIX 5.3 - and the oldest libraries - test_math passes. When I run the test on POWER8, using either xlc or gcc test_math fails with just one element of the test. When I run

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

David Edelsohn added the comment: nextafter is a known problem on AIX. I believe that it is being addressed in newer releases of AIX. Michael and I are helping the IBM AIX Open Source team to increase their attention on Python, but things only move so fast. --

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

STINNER Victor added the comment: > That sounds more like a process problem than a CPython codebase one. The > ideal would be that the machinery sending those notifications can be > configured to ignore known failures when deciding whether to send email. Is > that remotely feasible? (I have

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

Mark Dickinson added the comment: > My worry is that I'm getting emails about AIX buildbot failures. That sounds more like a process problem than a CPython codebase one. The ideal would be that the machinery sending those notifications can be configured to ignore known failures when

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

STINNER Victor added the comment: My worry is that I'm getting emails about AIX buildbot failures. I see different options: * Skip the test on AIX * Fix nextafter() on AIX * Turn off AIX buildbot email notifications * Remove thE AIX buildbot --

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

Mark Dickinson added the comment: Is there any reasonable channel for reporting the issue upstream? -- ___ Python tracker ___ ___

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

Mark Dickinson added the comment: If AIX were one of our officially supported platforms, then yes, I'd say that we should add a workaround to handle special cases ourselves, similarly to what we already do for a number of math module functions (like math.pow, for example). But given that

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

Change by Karthikeyan Singaravelan : -- nosy: +Michael.Felt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

New submission from STINNER Victor : https://buildbot.python.org/all/#/builders/302/builds/338 FAIL: test_nextafter (test.test_math.MathTests) -- Traceback (most recent call last): File