[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

Jason R. Coombs added the comment: New changeset fbf75b9997e280b1220755d0a17dbed71240d42e by Jason R. Coombs in branch 'master': Revert "bpo-42405: fix C extensions build on Windows ARM64 (GH-23399)" (#24753) https://github.com/python/cpython/commit/fbf75b9997e280b1220755d0a17dbed71240d42e

[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

Change by Jason R. Coombs : -- pull_requests: +23524 pull_request: https://github.com/python/cpython/pull/24753 ___ Python tracker ___

[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

Jason R. Coombs added the comment: Hey Steve. Thanks for the clarification. I'd forgotten the context, specifically that any patches needed to be merged before the PEP was accepted, and was working from a memory that we were willing to accept this change. Happy to revert it, as that also

[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

Steve Dower added the comment: Jason, this issue and the associated PR are out of date and should not be merged. The PR also only affects completely unused code, so it has no value whatsoever being in CPython. I don't really care too much about the unused code, but I will *insist* on the

[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

miss-islington added the comment: New changeset cb7bc7640935f6b05e9d2acfe4b33d496e8f8666 by Adrian Vladu in branch 'master': bpo-42405: fix C extensions build on Windows ARM64 (GH-23399) https://github.com/python/cpython/commit/cb7bc7640935f6b05e9d2acfe4b33d496e8f8666 -- nosy:

[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

Steve Dower added the comment: Closed due to PEP 632 (distutils is now deprecated). Changes to support this should go into setuptools or another build backend. I'm already trying to get some resources together to help these other projects build/test on ARM64, so that should help. If someone

[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

Jason R. Coombs added the comment: As I reviewed the PR, I do realize how tricky this change is going to be. In addition to the three MSVC implementations in distutils, Setuptools has its own (https://github.com/pypa/setuptools/blob/master/setuptools/msvc.py). Interestingly, that file

[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

Jason R. Coombs added the comment: If you wish for the functionality to be available in setuptools (backported), please contribute the change at https://github.com/pypa/distutils. At some point, contributions to CPython will also be synced there as well, and any changes there get synced

[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

Adrian Vladu added the comment: Thank you for the suggestion, I will update the PR accordingly to change the __msvccompiler.py. I just need to find a good candidate that uses that implementation to check if the compilation gets fixed. -- ___

[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

Steve Dower added the comment: There is no ARM64 release of Python for Windows right now, so unfortunately this doesn't constitute any kind of bugfix. We don't have a buildbot, and nobody out there has CI, so it's not a supported platform. I get that it's easier to centrally fix all the

[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

Adrian Vladu added the comment: This fix is __required__ to build a lot of important packages in the python ecosystem, like numpy, pandas, pywin32 and probably a lot more, as most of these important packages have not migrated to setuptools and usually maintain support for multiple python

[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

Steve Dower added the comment: Firstly, msvc9compiler.py is very deprecated, we don't touch that one at all or use it in distutils. Second, _msvccompiler.py is weakly deprecated (and likely soon fully deprecated), so you'd be better to make the fix in the setuptools project instead. But

[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

Change by Adrian Vladu : -- keywords: +patch pull_requests: +22291 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23399 ___ Python tracker ___

[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

New submission from Adrian Vladu : To add support for building packages that have C extensions on Windows ARM64, some fixes are required in the integrated distutils wrapper for Visual Studio compiler (Lib/distutils/msvc9compiler.py) This is a hardcoded fix that needs to be improved so that