[issue42412] Fix bases issues in PyType_FromModuleAndSpec()

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue42412] Fix bases issues in PyType_FromModuleAndSpec()

miss-islington added the comment: New changeset d153eb8a1e47123ecdb3fb47995a2c39ce7713ea by Miss Islington (bot) in branch '3.9': bpo-42412: Fix possible leaks and check arguments in PyType_FromModuleAndSpec() (GH-23410) https://github.com/python/cpython/commit/d153eb8a1e47123ecdb3fb47995a2c

[issue42412] Fix bases issues in PyType_FromModuleAndSpec()

miss-islington added the comment: New changeset 648a32b12ec676036ae4115747d458fb6f379d74 by Miss Islington (bot) in branch '3.8': bpo-42412: Fix possible leaks and check arguments in PyType_FromModuleAndSpec() (GH-23410) https://github.com/python/cpython/commit/648a32b12ec676036ae4115747d458

[issue42412] Fix bases issues in PyType_FromModuleAndSpec()

Change by miss-islington : -- pull_requests: +22334 pull_request: https://github.com/python/cpython/pull/23442 ___ Python tracker ___ __

[issue42412] Fix bases issues in PyType_FromModuleAndSpec()

Change by miss-islington : -- nosy: +miss-islington nosy_count: 1.0 -> 2.0 pull_requests: +22332 pull_request: https://github.com/python/cpython/pull/23440 ___ Python tracker _

[issue42412] Fix bases issues in PyType_FromModuleAndSpec()

Serhiy Storchaka added the comment: New changeset 1db76394ea79030aa4ed5349c950f6c6da51450f by Serhiy Storchaka in branch 'master': bpo-42412: Fix possible leaks and check arguments in PyType_FromModuleAndSpec() (GH-23410) https://github.com/python/cpython/commit/1db76394ea79030aa4ed5349c950f

[issue42412] Fix bases issues in PyType_FromModuleAndSpec()

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +22303 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23410 ___ Python tracker ___

[issue42412] Fix bases issues in PyType_FromModuleAndSpec()

New submission from Serhiy Storchaka : 1. There are leaks if Py_tp_bases is used more than once and if some some calls before setting tp_bases are failed. 2. There is a crash if the bases argument or Py_tp_bases is not a tuple. 3. The documentation is not accurate. -- components: C A