[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Change by Ned Deily : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Łukasz Langa added the comment: New changeset b29d0a5a7811418c0a1082ca188fd4850185e290 by Ned Deily in branch '3.8': [3.8] bpo-41100: Support macOS 11 Big Sur and Apple Silicon Macs (#25806) https://github.com/python/cpython/commit/b29d0a5a7811418c0a1082ca188fd4850185e290 -- nosy:

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Change by Ned Deily : -- pull_requests: +24492 pull_request: https://github.com/python/cpython/pull/25806 ___ Python tracker ___

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Ned Deily added the comment: New changeset d6675fee1aac1af87dc31c411d04a5bfc1f39079 by Miss Islington (bot) in branch '3.9': bpo-42504: Ensure that get_config_var('MACOSX_DEPLOYMENT_TARGET') is a string (GH-24341) (GH-24410)

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Change by miss-islington : -- pull_requests: +23225 pull_request: https://github.com/python/cpython/pull/24410 ___ Python tracker ___

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Ned Deily added the comment: New changeset 49926cf2bcc8b44d9b8f148d81979ada191dd9d5 by Ronald Oussoren in branch 'master': bpo-42504: Ensure that get_config_var('MACOSX_DEPLOYMENT_TARGET') is a string (GH-24341)

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Ronald Oussoren added the comment: see PR 24341. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Change by Ronald Oussoren : -- pull_requests: +23160 pull_request: https://github.com/python/cpython/pull/24341 ___ Python tracker ___

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Ronald Oussoren added the comment: I will create a PR later today, I've already committed the work in a branch of my clone of cpython. -- ___ Python tracker ___

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Lonny Kapelushnik added the comment: I believe this is causing issues when trying to install pyjq (https://github.com/doloopwhile/pyjq/issues/54). @ronaldoussoren are you still planning on creating a patch for this? Or should we plan on fixing it downstream? -- nosy: +lonnylot

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

mattip added the comment: It seems the approach that "The code for sysconfig.get_config_var() has a pretty clear intent: it will try to cast its return value to an int." has been accepted as true even though other parts of the code assumed the returned value was a string, and the CPython

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Ronald Oussoren added the comment: I'd prefer to (effectively) revert the PR and treat MACOSX_DEPLOYMENT_TARGET=11 the same as MACOSX_DEPLOYMENT_TARGET=11.0. The same issue has crept up on the wheel and packaging repos (in the context of changing the platform tag in wheel names). As I

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Ned Deily added the comment: I agree with Ronald that it would be safest if the sysconfigs (all of them) always returned deployment target as a string and I would be fine with a PR that did that. That doesn't mean that the already applied PR needs to be changed, though, right? Just extra

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Ronald Oussoren added the comment: The value *for this key* is a dot separated sequence of integer labels in a string. The limit of that is a single integer label that could be converted to a Python int. With the current patch get_config_var('MACOSX_DEPLOYMENT_TARGET') mostly returns a

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

FX Coudert added the comment: "It has always resulted in a string value": only MACOSX_DEPLOYMENT_TARGET always took the form of a non-integer. The code for sysconfig.get_config_var() has a pretty clear intent: it will try to cast its return value to an int. I don't have a strong opinion

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Ronald Oussoren added the comment: FWIW I don't agree with this fix. sys.get_config_var('MACOSX_DEPLOYMENT_TARGET') has always resulted in a string value. There's bound to be someone relying on this. As I wrote in comment on the PR a nicer fix is to teach sysconfig (and

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

miss-islington added the comment: New changeset 09a698b4743c669983d606595a1b2daeff6c3cf8 by Miss Islington (bot) in branch '3.9': bpo-42504: fix for MACOSX_DEPLOYMENT_TARGET=11 (GH-23556) https://github.com/python/cpython/commit/09a698b4743c669983d606595a1b2daeff6c3cf8 --

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Change by Ned Deily : -- versions: +Python 3.10, Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +22490 pull_request: https://github.com/python/cpython/pull/23622 ___ Python tracker

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Ned Deily added the comment: New changeset 5291639e611dc3f55a34666036f2c3424648ba50 by FX Coudert in branch 'master': bpo-42504: fix for MACOSX_DEPLOYMENT_TARGET=11 (GH-23556) https://github.com/python/cpython/commit/5291639e611dc3f55a34666036f2c3424648ba50 --

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Ronald Oussoren added the comment: Good catch. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Change by FX Coudert : -- keywords: +patch pull_requests: +22437 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23556 ___ Python tracker ___

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

Change by James Guillochon : -- components: +macOS nosy: +ned.deily, ronaldoussoren ___ Python tracker ___ ___ Python-bugs-list

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

New submission from FX Coudert : With macOS Big Sur (11.y.z), the major version is 11 (instead of the earlier 10.15, 10.14, etc). Therefore, MACOSX_DEPLOYMENT_TARGET=11 has become a valid setting. It is accepted by system tools: $ MACOSX_DEPLOYMENT_TARGET=11 clang a.c && echo $? 0 But it