[issue42576] Passing keyword arguments to types.GenericAlias causes a hard crash

2020-12-06 Thread miss-islington
miss-islington added the comment: New changeset 8502d46e3649bedf6b58a30b0a4b6b726e32b84b by Miss Islington (bot) in branch '3.9': [3.9] bpo-42576: Clarify only debug builds are affected in news (GH-23663) (GH-23666)

[issue42576] Passing keyword arguments to types.GenericAlias causes a hard crash

2020-12-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +22533 pull_request: https://github.com/python/cpython/pull/23666 ___ Python tracker ___

[issue42576] Passing keyword arguments to types.GenericAlias causes a hard crash

2020-12-06 Thread miss-islington
miss-islington added the comment: New changeset 6a7fb9d31bce8590e30c44458d1fc1da4539743d by kj in branch 'master': bpo-42576: Clarify only debug builds are affected in news (GH-23663) https://github.com/python/cpython/commit/6a7fb9d31bce8590e30c44458d1fc1da4539743d --

[issue42576] Passing keyword arguments to types.GenericAlias causes a hard crash

2020-12-06 Thread Ken Jin
Change by Ken Jin : -- pull_requests: +22530 pull_request: https://github.com/python/cpython/pull/23663 ___ Python tracker ___ ___

[issue42576] Passing keyword arguments to types.GenericAlias causes a hard crash

2020-12-06 Thread Ken Jin
Ken Jin added the comment: Thanks for taking the time to review this! I forgot to specify this only affects debug builds in the news entry. I'm opening a PR to edit that because I don't want people to mistake it for an actual interpreter-crashing bug in the release build (that would

[issue42576] Passing keyword arguments to types.GenericAlias causes a hard crash

2020-12-05 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks for the quick fix! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue42576] Passing keyword arguments to types.GenericAlias causes a hard crash

2020-12-05 Thread Ken Jin
Change by Ken Jin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue42576] Passing keyword arguments to types.GenericAlias causes a hard crash

2020-12-05 Thread miss-islington
miss-islington added the comment: New changeset d5c029b1a9b47737efb8966f804d28b99a2de239 by Miss Islington (bot) in branch '3.9': bpo-42576: Raise TypeError when passing in keyword arguments to GenericAlias (GH-23656)

[issue42576] Passing keyword arguments to types.GenericAlias causes a hard crash

2020-12-05 Thread miss-islington
miss-islington added the comment: New changeset 804d6893b801e8f30318afc38c20d4d0e6161db3 by kj in branch 'master': bpo-42576: Raise TypeError when passing in keyword arguments to GenericAlias (GH-23656) https://github.com/python/cpython/commit/804d6893b801e8f30318afc38c20d4d0e6161db3

[issue42576] Passing keyword arguments to types.GenericAlias causes a hard crash

2020-12-05 Thread miss-islington
Change by miss-islington : -- pull_requests: +22526 pull_request: https://github.com/python/cpython/pull/23659 ___ Python tracker ___

[issue42576] Passing keyword arguments to types.GenericAlias causes a hard crash

2020-12-05 Thread Guido van Rossum
Guido van Rossum added the comment: Oh, this looks like I copied the wrong idiom. Good catch! -- ___ Python tracker ___ ___

[issue42576] Passing keyword arguments to types.GenericAlias causes a hard crash

2020-12-05 Thread Ken Jin
Change by Ken Jin : -- keywords: +patch pull_requests: +22524 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23656 ___ Python tracker ___

[issue42576] Passing keyword arguments to types.GenericAlias causes a hard crash

2020-12-05 Thread Ken Jin
New submission from Ken Jin : I noticed that passing keyword arguments to types.GenericAlias's __new__ causes the interpreter to hard crash and exit due to an assertion failure: import types types.GenericAlias(bad=float) Result: Assertion failed: PyTuple_CheckExact(kwnames), file