[issue42599] Remove PyModule_GetWarningsModule() in pylifecycle.c

STINNER Victor added the comment: > When was the visibility changed to hidden? In Python 3.9: commit 0b60f64e4343913b4931dc27379d9808e5b78fe1 Author: Vinay Sajip Date: Tue Oct 15 08:26:12 2019 +0100 bpo-11410: Standardize and use symbol visibility attributes across POSIX and

[issue42599] Remove PyModule_GetWarningsModule() in pylifecycle.c

STINNER Victor added the comment: New changeset 0f91f586ae9b76c3bb44559bd8cd473b1b8de5ff by Hai Shi in branch 'master': bpo-42599: Remove useless PyModule_GetWarningsModule() (GH-23691) https://github.com/python/cpython/commit/0f91f586ae9b76c3bb44559bd8cd473b1b8de5ff --

[issue42599] Remove PyModule_GetWarningsModule() in pylifecycle.c

Petr Viktorin added the comment: When was the visibility changed to hidden? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue42599] Remove PyModule_GetWarningsModule() in pylifecycle.c

hai shi added the comment: > But it would not harm to document the removal in > https://docs.python.org/dev/whatsnew/3.10.html#id4 section. Copy that. I will update it soon. -- ___ Python tracker

[issue42599] Remove PyModule_GetWarningsModule() in pylifecycle.c

Change by hai shi : -- keywords: +patch pull_requests: +22559 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23691 ___ Python tracker ___

[issue42599] Remove PyModule_GetWarningsModule() in pylifecycle.c

STINNER Victor added the comment: It's not part of the C API and it's no longer exported in libpython since we (the default visibility was changed to "hidden"). IMHO it's safe to remove the function. But it would not harm to document the removal in

[issue42599] Remove PyModule_GetWarningsModule() in pylifecycle.c

New submission from hai shi : PyModule_GetWarningsModule() of pylifecycle.c is useless when _warning module was converted to a builtin module in 2.6. So move it directly now is OK. -- components: Interpreter Core messages: 382727 nosy: petr.viktorin, shihai1991, vstinner priority: