[issue42609] Eval with too high string multiplication crashes newer Python versions

Irit Katriel added the comment: Apart from the 3.9 backport this is complete. -- nosy: +iritkatriel, lukasz.langa versions: -Python 3.7, Python 3.8 ___ Python tracker ___

[issue42609] Eval with too high string multiplication crashes newer Python versions

Change by Serhiy Storchaka : -- pull_requests: +24328 pull_request: https://github.com/python/cpython/pull/25634 ___ Python tracker ___

[issue42609] Eval with too high string multiplication crashes newer Python versions

Serhiy Storchaka added the comment: New changeset face87c94e67ad9c72b9a3724f112fd76c1002b9 by Serhiy Storchaka in branch 'master': bpo-42609: Check recursion depth in the AST validator and optimizer (GH-23744) https://github.com/python/cpython/commit/face87c94e67ad9c72b9a3724f112fd76c1002b9

[issue42609] Eval with too high string multiplication crashes newer Python versions

Change by Batuhan Taskaya : -- nosy: +BTaskaya ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42609] Eval with too high string multiplication crashes newer Python versions

Serhiy Storchaka added the comment: This is known issue, but interesting that the cause of the crash is different in 3.7-3.8 and 3.9+. PR 23744 adds recursion checks in the AST validator and optimizer similar to the checks in the symtable. It should not break any existing code because too

[issue42609] Eval with too high string multiplication crashes newer Python versions

Change by Serhiy Storchaka : -- keywords: +patch nosy: +serhiy.storchaka nosy_count: 6.0 -> 7.0 pull_requests: +22602 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23744 ___ Python tracker

[issue42609] Eval with too high string multiplication crashes newer Python versions

Change by hongweipeng : -- nosy: +hongweipeng ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42609] Eval with too high string multiplication crashes newer Python versions

Change by Dong-hee Na : -- nosy: +methane ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42609] Eval with too high string multiplication crashes newer Python versions

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42609] Eval with too high string multiplication crashes newer Python versions

Steve Stagg added the comment: In python 3.7/8, It's a stack overflow in the constant folding code. On master, the overflow seems to come out of validate_expr.c. * thread #1, name = 'python3', stop reason = signal SIGSEGV: invalid address (fault address: 0x7f7feff8) frame #0:

[issue42609] Eval with too high string multiplication crashes newer Python versions

Steve Stagg added the comment: Looks like it was introduced by https://github.com/python/cpython/commit/7ea143ae795a9fd57eaccf490d316bdc13ee9065: bpo-29469: Move constant folding to AST optimizer (GH-2858) -- nosy: +stestagg ___ Python tracker

[issue42609] Eval with too high string multiplication crashes newer Python versions

Change by pmp-p : -- nosy: +pmpp ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42609] Eval with too high string multiplication crashes newer Python versions

Change by Erik Lamers : -- title: Eval with two high string multiplication crashes newer Python versions -> Eval with too high string multiplication crashes newer Python versions ___ Python tracker