[issue42944] random.Random.sample bug when counts is not None

Raymond Hettinger added the comment: Thanks for the report and the PR. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue42944] random.Random.sample bug when counts is not None

Raymond Hettinger added the comment: New changeset a90539f5723a4c34430761be8cba97daa8474abf by Miss Islington (bot) in branch '3.9': bpo-42944 Fix Random.sample when counts is not None (GH-24235) (GH-24243) https://github.com/python/cpython/commit/a90539f5723a4c34430761be8cba97daa8474abf

[issue42944] random.Random.sample bug when counts is not None

Change by miss-islington : -- nosy: +miss-islington nosy_count: 2.0 -> 3.0 pull_requests: +23065 pull_request: https://github.com/python/cpython/pull/24243 ___ Python tracker

[issue42944] random.Random.sample bug when counts is not None

Raymond Hettinger added the comment: New changeset f7b5bacd7a0b2084ce699eda6f6f4b1adfa16590 by jonanifranco in branch 'master': bpo-42944 Fix Random.sample when counts is not None (GH-24235) https://github.com/python/cpython/commit/f7b5bacd7a0b2084ce699eda6f6f4b1adfa16590 --

[issue42944] random.Random.sample bug when counts is not None

Jon FRANCO added the comment: PR submitted. Let me know if I missed something, this is also my first PR. Regards. -- ___ Python tracker ___

[issue42944] random.Random.sample bug when counts is not None

Change by Jon FRANCO : -- keywords: +patch pull_requests: +23058 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24235 ___ Python tracker ___

[issue42944] random.Random.sample bug when counts is not None

Raymond Hettinger added the comment: Would you like to submit a PR for this? -- ___ Python tracker ___ ___ Python-bugs-list

[issue42944] random.Random.sample bug when counts is not None

Change by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42944] random.Random.sample bug when counts is not None

New submission from Jon FRANCO : Hello, If I am reading right, random.Random.sample method has a bug if counts is not None. Line 482 (of master): """ selections = sample(range(total), k=k) """ this is calling the module function 'sample' and not the instance method. IMO this