[issue43121] Incorrect SyntaxError message for missing comma (3.10.a5)

Alex Hall added the comment: Pablo, check out https://github.com/aroberge/friendly/discussions/197, particularly the second bullet point which has a dataset of syntax errors. -- nosy: +alexmojaki ___ Python tracker

[issue43121] Incorrect SyntaxError message for missing comma (3.10.a5)

Andre Roberge added the comment: Pablo: The tests are in https://github.com/aroberge/friendly-traceback/tree/master/tests/syntax I plan to soon add at least two dozen more based on recent contributions. The full results can be seen on the documentation site; for example

[issue43121] Incorrect SyntaxError message for missing comma (3.10.a5)

Pablo Galindo Salgado added the comment: Thanks Andre for the thorough explanation! The reason I was interested in running it myself is that as you are running on syntax errors, is a good corpus of things that fail with error messages, which is something that we have not been able to find

[issue43121] Incorrect SyntaxError message for missing comma (3.10.a5)

Andre Roberge added the comment: Pablo: to run the friendly-traceback test suite is simply a matter of typing "pytest" from the root directory of the repository (after installing the dependencies). However, it would not be helpful for the purpose of CPython development, as likely more

[issue43121] Incorrect SyntaxError message for missing comma (3.10.a5)

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue43121] Incorrect SyntaxError message for missing comma (3.10.a5)

Pablo Galindo Salgado added the comment: New changeset d4e6ed7e5fb43320ea714d7436bc11667c624d43 by Pablo Galindo in branch 'master': bpo-43121: Fix incorrect SyntaxError message for missing comma (GH-24436) https://github.com/python/cpython/commit/d4e6ed7e5fb43320ea714d7436bc11667c624d43

[issue43121] Incorrect SyntaxError message for missing comma (3.10.a5)

Pablo Galindo Salgado added the comment: > Pablo: I have almost exactly the same 4 test cases that you added in the test > suite, so it would pass my tests too. I would consider it to be resolved. Fantastic. Also, for the future, could you indicate how could I run the test suite of

[issue43121] Incorrect SyntaxError message for missing comma (3.10.a5)

Andre Roberge added the comment: Pablo: I have almost exactly the same 4 test cases that you added in the test suite, so it would pass my tests too. I would consider it to be resolved. (For example:

[issue43121] Incorrect SyntaxError message for missing comma (3.10.a5)

Pablo Galindo Salgado added the comment: Andre, could you check if this works in your test suite correctly? -- ___ Python tracker ___

[issue43121] Incorrect SyntaxError message for missing comma (3.10.a5)

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +23244 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24436 ___ Python tracker

[issue43121] Incorrect SyntaxError message for missing comma (3.10.a5)

Pablo Galindo Salgado added the comment: Thanks Andre for the report. Will fix it soon -- ___ Python tracker ___ ___

[issue43121] Incorrect SyntaxError message for missing comma (3.10.a5)

Change by Irit Katriel : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43121] Incorrect SyntaxError message for missing comma (3.10.a5)

New submission from Andre Roberge : A missing comma between list items results in an incorrect message. Python 3.10.0a5 (tags/v3.10.0a5:b0478d7, Feb 3 2021, 01:44:54) [MSC v.1928 64 bit (AMD64)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> a = [1, 2