[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker ___

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Berker Peksag added the comment: New changeset 2183d06bc8a481098d62a4ebed8d6982b3d1602a by Erlend Egeberg Aasland in branch 'master': bpo-43251: sqlite3_column_name() failures now raise MemoryError (GH-24609) https://github.com/python/cpython/commit/2183d06bc8a481098d62a4ebed8d6982b3d1602a

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Erlend Egeberg Aasland added the comment: I believe we can proceed with this as planned. Serhiy, do you have additional comments or change requests? -- ___ Python tracker

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Erlend Egeberg Aasland added the comment: Larry Brasfield's comment https://sqlite.org/forum/forumpost/6430fc589d?t=h aligns with https://bugs.python.org/issue43251#msg387428 I'll think twice before posting there again, though. -- ___ Python

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Erlend Egeberg Aasland added the comment: Sure! Here it is: https://sqlite.org/forum/forumpost/574c6bc66c -- ___ Python tracker ___

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Serhiy Storchaka added the comment: Could you please give a link to the discussion? -- ___ Python tracker ___ ___ Python-bugs-list

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Erlend Egeberg Aasland added the comment: After discussing the matter briefly on the SQLite forum, I'm no longer 100% certain about this. There seems to be uncertainty about which other conditions can produce NULL, although memory error seems to be the most probable. I consider closing both

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Change by Erlend Egeberg Aasland : -- keywords: +patch pull_requests: +23388 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24609 ___ Python tracker

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Erlend Egeberg Aasland added the comment: Will do. Thanks for pushing the investigation. -- ___ Python tracker ___ ___

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Serhiy Storchaka added the comment: Please go ahead! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Erlend Egeberg Aasland added the comment: "SELECT 1" yields "1" as column name. "SELECT <...> AS N" yields "N" as column name. "SELECT NULL" yields "NULL" as column name. We can't set the column name via the API, so that's pretty much it (implicit name or explicit through the AS keyword). As

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Serhiy Storchaka added the comment: Investigate where column names are initialized and whether is it possible to get them NULLs. The array of column names is filled with NULLs when initialized and later it is filled with references to strings. I am wondering whether there is a gap between

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Erlend Egeberg Aasland added the comment: That's inside sqlite3_value_text() and friends, then? Let's investigate further before concluding. -- ___ Python tracker ___

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Serhiy Storchaka added the comment: It also returns NULL if the column name was not set (is it even possible?). -- ___ Python tracker ___

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

Change by Erlend Egeberg Aasland : -- title: sqlite3_column_name() failures should raise MemoryError -> [sqlite3] sqlite3_column_name() failures should raise MemoryError ___ Python tracker