[issue43344] RotatingFileHandler breaks file type associations

Vinay Sajip added the comment: > Could you please share best practices, looks like this documentation is > missing. I don't think so, because the implementation of the namer is up to the user. Note that this specific issue relates to RotatingFileHandler, not TimedRotatingFileHandler. I

[issue43344] RotatingFileHandler breaks file type associations

Alexander Smirnov added the comment: the namer was implemented to add "*.log" extension, to avoid broken file association problem. ``` log_handler.namer = lambda name: name.replace(".log", "") + ".log" ``` >implemented carefully enough Could you please share best practices, looks like this

[issue43344] RotatingFileHandler breaks file type associations

Vinay Sajip added the comment: > the problem with namer solution is that it will stop respecting backupCount > parameter Not necessarily, as far as I can tell. Can you give a specific rationale for your statement - how does that happen, if the namer has been implemented carefully enough?

[issue43344] RotatingFileHandler breaks file type associations

Alexander Smirnov added the comment: the problem with namer solution is that it will stop respecting backupCount parameter -- nosy: +alexander.smirnoff ___ Python tracker

[issue43344] RotatingFileHandler breaks file type associations

Change by Vinay Sajip : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue43344] RotatingFileHandler breaks file type associations

Kevin Hollingshead added the comment: Thanks Vinay, I was able to do this with: def namer(name): return name.replace(".log", "") + ".log" Then when initializing the logger: handler.namer = namer My full initializer script: import os import logging from logging.handlers import

[issue43344] RotatingFileHandler breaks file type associations

Vinay Sajip added the comment: I'll add to the cookbook recipe with this real-world example, when I get a chance. -- ___ Python tracker ___

[issue43344] RotatingFileHandler breaks file type associations

Vinay Sajip added the comment: > Thanks Vinay, I was able to do this Glad to hear it, Kevin. That namer is exactly what I had in my mind's eye ;-) So shall I close the issue? -- ___ Python tracker

[issue43344] RotatingFileHandler breaks file type associations

Kevin Hollingshead added the comment: Sure. Thanks for your help. On Tue, Mar 2, 2021, 1:08 PM Vinay Sajip wrote: > > Vinay Sajip added the comment: > > I'll add to the cookbook recipe with this real-world example, when I get a > chance. > > -- > >

[issue43344] RotatingFileHandler breaks file type associations

Vinay Sajip added the comment: As per the documentation at https://docs.python.org/3/library/logging.handlers.html#logging.handlers.BaseRotatingHandler.namer You can set the handler's "namer" attribute to a callable that returns a computed name for the rotated file - this can be computed as

[issue43344] RotatingFileHandler breaks file type associations

Raymond Hettinger added the comment: +1 The ability to customize the filenames seems like a reasonable feature request. Perhaps an optional *format* option could introduced. -- nosy: +rhettinger, vinay.sajip versions: +Python 3.10 ___ Python

[issue43344] RotatingFileHandler breaks file type associations

New submission from Kevin Hollingshead : The filenames generated by logging.RotatingFileHandler breaks the ability to associate a program (e.g. notepad++, sublime text, etc.) with the log files using Windows or OSX file associations because the extension is overridden by the added suffix.