[issue43359] Dead assignment in Py_UniversalNewlineFgets

Irit Katriel added the comment: That function has been edited in the meantime and this line is no longer there. -- nosy: +iritkatriel resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue43359] Dead assignment in Py_UniversalNewlineFgets

STINNER Victor added the comment: > Hi Victor, just so we're all on the same page, removing the line does not > trigger a compiler warning. The comment on this line is misleading. I wrote the opposite. IMO the line and its commment should be kept. > Defect identified by scan-build >

[issue43359] Dead assignment in Py_UniversalNewlineFgets

Alex Henrie added the comment: Hi Victor, just so we're all on the same page, removing the line does not trigger a compiler warning. The comment on this line is misleading. -- ___ Python tracker

[issue43359] Dead assignment in Py_UniversalNewlineFgets

STINNER Victor added the comment: > c = 'x'; /* Shut up gcc warning */ IMHO this code is fine and should be kept. I hate fighting against stupid false alarms of compiler warnings. This code is harmless. It doesn't affect performances or anything. I suggest to close this issue and its

[issue43359] Dead assignment in Py_UniversalNewlineFgets

Terry J. Reedy added the comment: Victor and/or Serhiy: This and #43360 and #43361 are similar 1-line changes, suggested by scan-build, to eliminate dead or duplicate initializations in C code. Can either of you either handle these or suggest someone else? Would we have preferred 1 issue