[issue43423] Subprocess IndexError possible in _communicate

miss-islington added the comment: New changeset ad83fde75463dad2df878ff264f52436eb48bc6b by Miss Islington (bot) in branch '3.9': bpo-43423 Fix IndexError in subprocess _communicate function (GH-24777) https://github.com/python/cpython/commit/ad83fde75463dad2df878ff264f52436eb48bc6b

[issue43423] Subprocess IndexError possible in _communicate

miss-islington added the comment: New changeset 1a5001c606b55226c03fa1046aa8f5e1db2fa67d by Miss Islington (bot) in branch '3.8': bpo-43423 Fix IndexError in subprocess _communicate function (GH-24777) https://github.com/python/cpython/commit/1a5001c606b55226c03fa1046aa8f5e1db2fa67d

[issue43423] Subprocess IndexError possible in _communicate

Change by miss-islington : -- pull_requests: +23596 pull_request: https://github.com/python/cpython/pull/24831 ___ Python tracker ___

[issue43423] Subprocess IndexError possible in _communicate

Change by miss-islington : -- pull_requests: +23595 pull_request: https://github.com/python/cpython/pull/24830 ___ Python tracker ___

[issue43423] Subprocess IndexError possible in _communicate

Change by miss-islington : -- pull_requests: +23594 pull_request: https://github.com/python/cpython/pull/24823 ___ Python tracker ___

[issue43423] Subprocess IndexError possible in _communicate

Gregory P. Smith added the comment: The bug is fixed, Thanks Chris! There was a refactoring noted as being nice in my comments on the primary main branch PR that would be nice to have. But isn't critical. If you want to make a PR for that, just reuse this bpo-43423 issue number on the PR

[issue43423] Subprocess IndexError possible in _communicate

Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +23589 pull_request: https://github.com/python/cpython/pull/24824 ___ Python tracker

[issue43423] Subprocess IndexError possible in _communicate

Gregory P. Smith added the comment: New changeset b4fc44bb2d209182390b4f9fdf074a46b0165a2f by Chris Griffith in branch 'master': bpo-43423 Fix IndexError in subprocess _communicate function (GH-24777) https://github.com/python/cpython/commit/b4fc44bb2d209182390b4f9fdf074a46b0165a2f

[issue43423] Subprocess IndexError possible in _communicate

Eryk Sun added the comment: The presumption I suppose is that these statements only execute if self.stdout_thread and/or self.stderr_thread completes successfully. I suppose that the read could fail or get canceled via CancelSynchronousIo(). Of course in that case you have a bigger problem

[issue43423] Subprocess IndexError possible in _communicate

Change by Chris Griffith : -- keywords: +patch pull_requests: +23542 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24777 ___ Python tracker ___

[issue43423] Subprocess IndexError possible in _communicate

New submission from Chris Griffith : It is possible to run into an IndexError in the subprocess module's _communicate function. ``` return run( File "subprocess.py", line 491, in run File "subprocess.py", line 1024, in communicate File "subprocess.py", line 1418, in _communicate