[issue43709] Windows Tools\buildbot\clean.bat misses some needed pyc/pyo removal

2021-04-04 Thread David Bolen
David Bolen added the comment: No longer needed after commit c368ce74d2c9bcbf1ec320466819c2d4768252f7 -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue43709] Windows Tools\buildbot\clean.bat misses some needed pyc/pyo removal

2021-04-03 Thread David Bolen
David Bolen added the comment: Based on further information in issue #27129 as well as issue #43719 it appears a source of the problem prompting this fix was a failure to update the magic number in the original commit for #27129. The windows clean script does still leave more artifacts

[issue43709] Windows Tools\buildbot\clean.bat misses some needed pyc/pyo removal

2021-04-02 Thread David Bolen
Change by David Bolen : -- keywords: +patch pull_requests: +23904 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25157 ___ Python tracker ___

[issue43709] Windows Tools\buildbot\clean.bat misses some needed pyc/pyo removal

2021-04-02 Thread David Bolen
David Bolen added the comment: Something like this is a quick 'n dirty minimal fix - at least it seems to solve the problem that arose in issue #27129 on the Win10 buildbot: --- a/Tools/buildbot/clean.bat +++ b/Tools/buildbot/clean.bat @@ -11,6 +11,8 @@ call "%pcbuild%\build.bat" -t Clean -k

[issue43709] Windows Tools\buildbot\clean.bat misses some needed pyc/pyo removal

2021-04-02 Thread David Bolen
New submission from David Bolen : The Tools\buildbot\clean.bat script used on Windows only removes pyc/pyo files from the Lib tree, leaving some files beneath Tools (clinic and peg_generator) and Parser (asdl). This can cause failures following commits that affect those files, such as