[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

miss-islington added the comment: New changeset 3ea2a8f425d26e81d914c54d477e9d56eb27ac98 by Erlend Egeberg Aasland in branch '3.9': [3.9] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-31030) (GH-31586)

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Change by Erlend E. Aasland : -- pull_requests: +29709 pull_request: https://github.com/python/cpython/pull/31586 ___ Python tracker ___

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Jelle Zijlstra added the comment: New changeset ba457fe6f8e50ad3ef3ceffb75dee96629a42ad7 by Erlend Egeberg Aasland in branch '3.10': [3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-31030) https://github.com/python/cpython/commit/ba457fe6f8e50ad3ef3ceffb75dee96629a42ad7

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Change by Erlend E. Aasland : -- pull_requests: +29211 pull_request: https://github.com/python/cpython/pull/31030 ___ Python tracker ___

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Guido van Rossum added the comment: New changeset 3eb3b4f270757f66c7fb6dcf5afa416ee1582a4b by Erlend Egeberg Aasland in branch 'main': bpo-43853: Expand test suite for SQLite UDF's (GH-27642) https://github.com/python/cpython/commit/3eb3b4f270757f66c7fb6dcf5afa416ee1582a4b -- nosy:

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Erlend E. Aasland added the comment: Serhiy, I believe I've addressed your review remarks on PR 27642. Would you mind taking a look at it again if you have time? -- ___ Python tracker

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Erlend E. Aasland added the comment: Thanks for merging the NEWS amendments, Pablo. We can close this issue after landing PR 27642. -- ___ Python tracker ___

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Pablo Galindo Salgado added the comment: New changeset b34ca7e0515e6726cf5e938f7239de41df710cfd by Erlend Egeberg Aasland in branch '3.10': [3.10] bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922). (GH-27953)

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Pablo Galindo Salgado added the comment: New changeset 0ec17a2494412ea7d76f7d0567b73c1fffa88c18 by Erlend Egeberg Aasland in branch '3.9': [3.9] bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922) (GH-27952)

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Change by Erlend E. Aasland : -- pull_requests: +26400 pull_request: https://github.com/python/cpython/pull/27953 ___ Python tracker ___

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Change by Erlend E. Aasland : -- pull_requests: +26399 pull_request: https://github.com/python/cpython/pull/27952 ___ Python tracker ___

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Pablo Galindo Salgado added the comment: New changeset 7903a1096343d8018e889029f025d39bdd077170 by Erlend Egeberg Aasland in branch 'main': bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922) https://github.com/python/cpython/commit/7903a1096343d8018e889029f025d39bdd077170

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Erlend E. Aasland added the comment: > What about new tests and NEWS update? See PR 27642 for the expanded tests, and PR 27922 for amending news entries. I didn't combine the two, as I figured you might have more comments on the former PR. --

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg399133 ___ Python tracker ___ ___ Python-bugs-list

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Change by Erlend E. Aasland : -- pull_requests: +26374 pull_request: https://github.com/python/cpython/pull/27922 ___ Python tracker ___

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Change by Erlend E. Aasland : -- pull_requests: +26136 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/27642 ___ Python tracker ___

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Erlend E. Aasland added the comment: Serhiy, what's the preferred way to append to existing NEWS entries: should I update the existing NEWS entries tied to this issue, or add new entries (with the same bpo number)? -- ___ Python tracker

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Change by Erlend E. Aasland : -- resolution: fixed -> status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Serhiy Storchaka added the comment: What about new tests and NEWS update? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Change by Erlend E. Aasland : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Serhiy Storchaka added the comment: New changeset 8c07fef867707694c9f2fcee4d7a9563ad78ed14 by Erlend Egeberg Aasland in branch '3.9': [3.9] bpo-43853: Handle sqlite3_value_text() errors (GH-25422). (GH-27627) https://github.com/python/cpython/commit/8c07fef867707694c9f2fcee4d7a9563ad78ed14

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Erlend E. Aasland added the comment: I'll add extra tests in a separate PR, so we can easily backport it to 3.10 and 3.9. -- ___ Python tracker ___

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Change by Erlend E. Aasland : -- pull_requests: +26121 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/27627 ___ Python tracker ___

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Serhiy Storchaka added the comment: I think it is worth to backport it to 3.9. It looks to me that it fixes also support of strings containing NUL. It would be nice to add corresponding tests for this. You can also add this in the NEWS entry for this issue. -- status: closed ->

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

miss-islington added the comment: New changeset 067d6d46575b5cf30bbf7c812defee1517106a34 by Miss Islington (bot) in branch '3.10': bpo-43853: Handle sqlite3_value_text() errors (GH-25422) https://github.com/python/cpython/commit/067d6d46575b5cf30bbf7c812defee1517106a34 --

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +25125 pull_request: https://github.com/python/cpython/pull/26534 ___ Python tracker

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Pablo Galindo Salgado added the comment: New changeset 006fd869e4798b68e266f5de89c83ddb531a756b by Erlend Egeberg Aasland in branch 'main': bpo-43853: Handle sqlite3_value_text() errors (GH-25422) https://github.com/python/cpython/commit/006fd869e4798b68e266f5de89c83ddb531a756b --

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Erlend E. Aasland added the comment: The affected branch is exercised by the following tests: - test_aggr_check_param_blob - test_aggr_check_param_float - test_aggr_check_param_int - test_aggr_check_param_none - test_aggr_check_param_str - test_aggr_check_params_int -

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

Change by Erlend E. Aasland : -- title: [sqlite3] Fix sqlite3_value_text() usage -> [sqlite3] Improve sqlite3_value_text() error handling ___ Python tracker ___