[issue43868] Remove PyOS_ReadlineFunctionPointer from the stable ABI list

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue43868] Remove PyOS_ReadlineFunctionPointer from the stable ABI list

Petr Viktorin added the comment: New changeset 91b69b77cf5f78de6d35dea23098df34b6fd9e53 by Petr Viktorin in branch 'master': bpo-43868: Remove PyOS_ReadlineFunctionPointer from the stable ABI list (GH-25442) https://github.com/python/cpython/commit/91b69b77cf5f78de6d35dea23098df34b6fd9e53

[issue43868] Remove PyOS_ReadlineFunctionPointer from the stable ABI list

STINNER Victor added the comment: Yes, please remove it from the limited C API. PyOS_ReadlineFunctionPointer has a bad API. I fixed recently PyOS_StdioReadline because it used the Python C API without holding the GIL. To acquire the GIL, you need to access a *private* _PyOS_ReadlineTState

[issue43868] Remove PyOS_ReadlineFunctionPointer from the stable ABI list

Change by Petr Viktorin : -- keywords: +patch pull_requests: +24172 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25442 ___ Python tracker ___

[issue43868] Remove PyOS_ReadlineFunctionPointer from the stable ABI list

New submission from Petr Viktorin : The inclusion of PyOS_ReadlineFunctionPointer in python3dll.c (*) was a mistake. According to PEP 384: > functions expecting FILE* are not part of the ABI, to avoid depending on a > specific version of the Microsoft C runtime DLL on Windows. The situation