[issue44039] Duplicated assignment in Modules/_randommodule.c

Brad Larsen added the comment: > Just curious, how did you find this? I am working on some new CodeQL queries (https://securitylab.github.com/tools/codeql/) and saw a warning about this self-assignment from one of the existing queries. LGTM apparently regularly scans cpython:

[issue44039] Duplicated assignment in Modules/_randommodule.c

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +24578 pull_request: https://github.com/python/cpython/pull/25909 ___ Python tracker

[issue44039] Duplicated assignment in Modules/_randommodule.c

Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue44039] Duplicated assignment in Modules/_randommodule.c

Raymond Hettinger added the comment: Just curious, how did you find this? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue44039] Duplicated assignment in Modules/_randommodule.c

Change by Raymond Hettinger : -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing

[issue44039] Duplicated assignment in Modules/_randommodule.c

Change by Brad Larsen : -- keywords: +patch pull_requests: +24572 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25904 ___ Python tracker ___

[issue44039] Duplicated assignment in Modules/_randommodule.c

New submission from Brad Larsen : In Modules/_randommodule.c:600, `longval` is used in its own initialization. This seems to be a typo introduced in commit cc0cd43c0f9 for bpo-1635741. 585 static int 586 _random_exec(PyObject *module) 587 { 588 _randomstate *state =