[issue44092] [sqlite3] consider removing special rollback handling

Erlend E. Aasland added the comment: I've crafted a number of rollback tests, but it occurred to me that they are simply just testing SQLite behaviour; not sqlite3 behaviour. I had to adjust the tests according to which version of SQLite was used (for example 3.8.7.2 introduced new behaviour

[issue44092] [sqlite3] consider removing special rollback handling

Erlend E. Aasland added the comment: The effect of PR 26026 is that InterfaceError is no longer raised for fetch across rollback; instead it is up to SQLite how to handle this: - for some cases, SQLITE_ABORT or SQLITE_ABORT_ROLLBACK may be returned, which will result in an OperationalError (

[issue44092] [sqlite3] consider removing special rollback handling

Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg393339 ___ Python tracker ___ ___ Python-bugs-list mail

[issue44092] [sqlite3] consider removing special rollback handling

Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg393367 ___ Python tracker ___ ___ Python-bugs-list mail

[issue44092] [sqlite3] consider removing special rollback handling

Change by Erlend E. Aasland : Removed file: https://bugs.python.org/file50029/patch.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue44092] [sqlite3] consider removing special rollback handling

Change by Erlend E. Aasland : -- pull_requests: +24676 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26026 ___ Python tracker ___ ___

[issue44092] [sqlite3] consider removing special rollback handling

Erlend E. Aasland added the comment: Quoting pysqlite commit 5a009ed message (https://github.com/ghaering/pysqlite/commit/5a009ed6fb2e90b952438f5786f93cd1e8ac8722): "Implemented a function that resets all statements in the connection's statement cache. After calling this function it is alway

[issue44092] [sqlite3] consider removing special rollback handling

Erlend E. Aasland added the comment: BTW, the patch also removes resetting of cursors upon close, which is a little bit out of scope of this bpo. -- ___ Python tracker ___ __

[issue44092] [sqlite3] consider removing special rollback handling

Erlend E. Aasland added the comment: Attached patch includes the test case from bpo-33376. -- ___ Python tracker ___ ___ Python-bug

[issue44092] [sqlite3] consider removing special rollback handling

Change by Erlend E. Aasland : -- keywords: +patch Added file: https://bugs.python.org/file50029/patch.diff ___ Python tracker ___ __

[issue44092] [sqlite3] consider removing special rollback handling

New submission from Erlend E. Aasland : Ref. bpo-33376 and bpo-10513. Quoting from the SQLite 3.7.11 changelog[1]: "Pending statements no longer block ROLLBACK. Instead, the pending statement will return SQLITE_ABORT upon next access after the ROLLBACK." Quoting from the SQLite 3.8.7.2 change