[issue44165] [sqlite3] sqlite3_prepare_v2 micro optimisation: pass string size

Change by Erlend E. Aasland : -- pull_requests: +25081 pull_request: https://github.com/python/cpython/pull/26485 ___ Python tracker ___

[issue44165] [sqlite3] sqlite3_prepare_v2 micro optimisation: pass string size

Erlend E. Aasland added the comment: > Erlend, check out > https://github.com/python/cpython/pull/26206#discussion_r643910263. After > that we can close this issue See msg393857: I'll add a PR for _pysqlite_connection_begin as well. After that, we can close this. --

[issue44165] [sqlite3] sqlite3_prepare_v2 micro optimisation: pass string size

Pablo Galindo Salgado added the comment: New changeset fbf25b8c0dd1e62db59117d53bbd2d4131a06867 by Erlend Egeberg Aasland in branch 'main': bpo-44165: pysqlite_statement_create now returns a Py object, not an int (GH-26484)

[issue44165] [sqlite3] sqlite3_prepare_v2 micro optimisation: pass string size

Change by Erlend E. Aasland : -- pull_requests: +25080 pull_request: https://github.com/python/cpython/pull/26484 ___ Python tracker ___

[issue44165] [sqlite3] sqlite3_prepare_v2 micro optimisation: pass string size

Pablo Galindo Salgado added the comment: Erlend, check out https://github.com/python/cpython/pull/26206#discussion_r643910263. After that we can close this issue -- ___ Python tracker

[issue44165] [sqlite3] sqlite3_prepare_v2 micro optimisation: pass string size

Pablo Galindo Salgado added the comment: New changeset a384b6c04054a2c5050a99059836175cf73e2016 by Erlend Egeberg Aasland in branch 'main': bpo-44165: Optimise sqlite3 statement preparation by passing string size (GH-26206)

[issue44165] [sqlite3] sqlite3_prepare_v2 micro optimisation: pass string size

Erlend E. Aasland added the comment: SQLITE_TOOBIG is currently mapped to sqlite3.DataError. In order to keep the current behaviour, DataError must be raised. -- ___ Python tracker

[issue44165] [sqlite3] sqlite3_prepare_v2 micro optimisation: pass string size

Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg393977 ___ Python tracker ___ ___ Python-bugs-list

[issue44165] [sqlite3] sqlite3_prepare_v2 micro optimisation: pass string size

Erlend E. Aasland added the comment: Regarding the maximum length of an SQL string, quoting from https://sqlite.org/limits.html: "The current implementation will only support a string or BLOB length up to 2^31-1 or 2147483647. And some built-in functions such as hex() might fail well before

[issue44165] [sqlite3] sqlite3_prepare_v2 micro optimisation: pass string size

Erlend E. Aasland added the comment: Regarding the maximum length of an SQL string, quoting from https://sqlite.org/limits.html: "The current implementation will only support a string or BLOB length up to 2^31-1 or 2147483647. And some built-in functions such as hex() might fail well before

[issue44165] [sqlite3] sqlite3_prepare_v2 micro optimisation: pass string size

Erlend E. Aasland added the comment: Note, PR 26206 does not include statement creation in _pysqlite_connection_begin (Modules/_sqlite/connection.c). That needs further refactoring, so I'll add that in a separate PR if PR 26206 is accepted. --

[issue44165] [sqlite3] sqlite3_prepare_v2 micro optimisation: pass string size

Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +24823 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26206 ___ Python tracker

[issue44165] [sqlite3] sqlite3_prepare_v2 micro optimisation: pass string size

New submission from Erlend E. Aasland : The signature of sqlite3_prepare_v2 is as follows: int sqlite3_prepare_v2( sqlite3 *db,/* Database handle */ const char *zSql, /* SQL statement, UTF-8 encoded */ int nByte, /* Maximum length of zSql in bytes. */