Antoine Pitrou pit...@free.fr added the comment:
max_buffer_size is no longer used, so this issue is obsolete ;)
--
resolution: - out of date
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4428
Changes by Gregory P. Smith g...@krypto.org:
Added file: http://bugs.python.org/file12914/issue4428-io-bufwrite-gps05.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4428
___
Gregory P. Smith g...@krypto.org added the comment:
I've uploaded a new patch set with more extensive unit tests. It also
handles the case of writing array.array objects (or anything with a
memoryview itemsize 1). The previous code would buffer by item rather
than by byte. it has been
Gregory P. Smith g...@krypto.org added the comment:
fwiw, I decided Guido and Antoine were right and took out the support
for input that did not support len() to keep things a bit simpler.
___
Python tracker rep...@bugs.python.org
: gregory.p.smith, pitrou
severity: normal
status: open
title: issue4428 - make io.BufferedWriter observe max_buffer_size limits
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5011
Gregory P. Smith g...@krypto.org added the comment:
Reviewers: Antoine Pitrou,
Message:
Just responding to your comments on the support for generators and non
buffer api supporting inputs.
I'll get to the other comments in the code soon with new unit tests for
those cases.
Antoine Pitrou pit...@free.fr added the comment:
Hi!
that sounds
like a behavior change. I'd be fine with removing it for the 3.1/2.7
version of
this code (though I hope people will be using the C implementation
instead).
Well, either it's supported and it will have to go through a
Guido van Rossum gu...@python.org added the comment:
@Gregory, that sounds like an odd enough use case to skip. However you
might want to look for __length_hint__ before giving up?
OTOH unless the use case is real, why not support it but making it slow?
___
