[issue44430] [sqlite3] refactor threading tests

Pablo Galindo Salgado added the comment: New changeset 5f0fc30de46d41dccf04096df12664fc0a684ca2 by Erlend Egeberg Aasland in branch 'main': bpo-44430: Refactor `sqlite3` threading tests (GH-26748) https://github.com/python/cpython/commit/5f0fc30de46d41dccf04096df12664fc0a684ca2 --

[issue44430] [sqlite3] refactor threading tests

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue44430] [sqlite3] refactor threading tests

Erlend E. Aasland added the comment: The current code duplication has several negative impacts, IMO: - Readability Currently the ThreadTests class spans 173 lines. Refactored, it spans 51 lines (should fit in a screenful), making it easy to see what's actually being tested. Currently,

[issue44430] [sqlite3] refactor threading tests

Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +25333 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26748 ___ Python tracker

[issue44430] [sqlite3] refactor threading tests

New submission from Erlend E. Aasland : The threading tests (ThreadTests) in Lib/sqlite3/test/dbapi.py has a lot of code duplication, and none of the test methods use the test.support.threading_helper.reap_threads helper. Also, some branches are not covered by this test class. Suggesting the