[issue44991] [sqlite3] cleanup callbacks (GIL handling, naming, ...)

Petr Viktorin added the comment: New changeset cfb1df3b71501a80ed57739181ec2ed30012c491 by Erlend Egeberg Aasland in branch 'main': bpo-44991: Normalise function and collation callback naming (GH-28209) https://github.com/python/cpython/commit/cfb1df3b71501a80ed57739181ec2ed30012c491

[issue44991] [sqlite3] cleanup callbacks (GIL handling, naming, ...)

Change by Erlend E. Aasland : -- pull_requests: +26634 pull_request: https://github.com/python/cpython/pull/28209 ___ Python tracker ___

[issue44991] [sqlite3] cleanup callbacks (GIL handling, naming, ...)

Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue44991] [sqlite3] cleanup callbacks (GIL handling, naming, ...)

Petr Viktorin added the comment: The remaining function_pinboard_* renames are part of PR-27940. -- ___ Python tracker ___ ___

[issue44991] [sqlite3] cleanup callbacks (GIL handling, naming, ...)

Petr Viktorin added the comment: New changeset 0474d06008f8c9eba660ed20d336ffdc5c4db121 by Erlend Egeberg Aasland in branch 'main': bpo-44991: Normalise `sqlite3` callback naming (GH-28088) https://github.com/python/cpython/commit/0474d06008f8c9eba660ed20d336ffdc5c4db121 --

[issue44991] [sqlite3] cleanup callbacks (GIL handling, naming, ...)

Change by Erlend E. Aasland : -- pull_requests: +26531 pull_request: https://github.com/python/cpython/pull/28088 ___ Python tracker ___

[issue44991] [sqlite3] cleanup callbacks (GIL handling, naming, ...)

miss-islington added the comment: New changeset 001ef4600f5ab2e1d7825ddbc0f253377c234d7e by Erlend Egeberg Aasland in branch 'main': bpo-44991: Make GIL handling more explicit in `sqlite3` callbacks (GH-27934) https://github.com/python/cpython/commit/001ef4600f5ab2e1d7825ddbc0f253377c234d7e

[issue44991] [sqlite3] cleanup callbacks (GIL handling, naming, ...)

Erlend E. Aasland added the comment: We'll do the changes Petr proposed first, and then I'll see how invasive the other changes will be. If the diffs end up being concise, I'll put them up for review :) -- ___ Python tracker

[issue44991] [sqlite3] cleanup callbacks (GIL handling, naming, ...)

Dong-hee Na added the comment: Obviously, this case could be code churn(we don't accept normally), but if other core-dev agree with the changes. I am fine. -- nosy: +corona10 ___ Python tracker

[issue44991] [sqlite3] cleanup callbacks (GIL handling, naming, ...)

Petr Viktorin added the comment: The general policy is to only improve style for code you touch for some other reasons. You're changing lots of the callback code in bpo-42064, so I reckon making things more readable is fine. -- ___ Python tracker

[issue44991] [sqlite3] cleanup callbacks (GIL handling, naming, ...)

Erlend E. Aasland added the comment: I'd like to propose further enhancements: - use intermingled declarations in the affected functions; this will make GIL acquisition stand more out, and it also improves readability and makes it easier to trace refs - take the naming step further: I'd