[issue45040] [sqlite3] optimise transaction control functions

2021-09-19 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45040] [sqlite3] optimise transaction control functions

2021-09-19 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 771a5467132f0400d4c987db8ba807f845b655bc by Erlend Egeberg Aasland in branch 'main': bpo-45040: Simplify sqlite3 transaction control functions (GH-28019) https://github.com/python/cpython/commit/771a5467132f0400d4c987db8ba807f845b655bc

[issue45040] [sqlite3] optimise transaction control functions

2021-08-28 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +26465 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28019 ___ Python tracker

[issue45040] [sqlite3] optimise transaction control functions

2021-08-28 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : pysqlite_connection_commit_impl(), pysqlite_connection_rollback_impl(), and begin_transaction() can be simplified: sqlite3_finalize() will pass on any error set by sqlite3_step(). This implies that we only need to check the return value of