[issue45122] Remove PyCode_New and PyCode_NewWithPosOnlyArgs

2021-09-07 Thread da-woods
da-woods added the comment: Done: https://github.com/Nuitka/Nuitka/issues/1203 -- ___ Python tracker ___ ___ Python-bugs-list

[issue45122] Remove PyCode_New and PyCode_NewWithPosOnlyArgs

2021-09-07 Thread Guido van Rossum
Guido van Rossum added the comment: Da-woods, can you take care of that? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue45122] Remove PyCode_New and PyCode_NewWithPosOnlyArgs

2021-09-07 Thread da-woods
da-woods added the comment: Nuitka (https://github.com/Nuitka/Nuitka/ - a third Python->C API compiler) also looks to use it so you might want to let them know too while you're doing the rounds on this. -- nosy: +da-woods ___ Python tracker

[issue45122] Remove PyCode_New and PyCode_NewWithPosOnlyArgs

2021-09-06 Thread Dong-hee Na
Dong-hee Na added the comment: I sent the patch for this issue: https://github.com/python/mypy/pull/11067 -- ___ Python tracker ___

[issue45122] Remove PyCode_New and PyCode_NewWithPosOnlyArgs

2021-09-06 Thread Dong-hee Na
Dong-hee Na added the comment: FYI, mypyc is using PyCode_New. mypyc should be fixed not to use PyCode_New :) -- ___ Python tracker ___

[issue45122] Remove PyCode_New and PyCode_NewWithPosOnlyArgs

2021-09-06 Thread Dong-hee Na
Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45122] Remove PyCode_New and PyCode_NewWithPosOnlyArgs

2021-09-06 Thread Guido van Rossum
Guido van Rossum added the comment: That sounds like a good plan (note that alpha 1 will go out around Oct 4). I left an issue for Cython: https://github.com/cython/cython/issues/4365 -- ___ Python tracker

[issue45122] Remove PyCode_New and PyCode_NewWithPosOnlyArgs

2021-09-06 Thread STINNER Victor
STINNER Victor added the comment: I understood that these function calls shoud be replaced with: * PyCode_NewEmpty(const char *filename, const char *funcname, int firstlineno) * code.replace() method: https://docs.python.org/dev/library/types.html#types.CodeType.replace --

[issue45122] Remove PyCode_New and PyCode_NewWithPosOnlyArgs

2021-09-06 Thread STINNER Victor
STINNER Victor added the comment: If possible, I suggest to do in in this order: * Fix Cython * Publish a Cython release including the fix * (Maybe wait a bit) * Remove the two functions Previously, we tried to first modified Python, and then update Cython: it went bad. Otherwise, the

[issue45122] Remove PyCode_New and PyCode_NewWithPosOnlyArgs

2021-09-06 Thread Guido van Rossum
Guido van Rossum added the comment: PS. It would be nice to also update Cython, which is the only thing that uses these C APIs. -- ___ Python tracker ___

[issue45122] Remove PyCode_New and PyCode_NewWithPosOnlyArgs

2021-09-06 Thread Guido van Rossum
New submission from Guido van Rossum : This is up for grabs. For reference, the Steering Council approved getting rid of these two C APIs without honoring the customary two-release deprecation period required by PEP 387. For reference see