[issue45187] Some tests in test_socket are not run

STINNER Victor added the comment: > bpo-45187: Collect test_socket tests using unittest (GH-28317) Nice enhancement! Thanks. > self.addCleanup(thread.join, self.timeout) I suggest to use test.support.threading_helper.join_thread() to avoid blocking if the thread raises an exception or

[issue45187] Some tests in test_socket are not run

Serhiy Storchaka added the comment: New changeset 6c50f23ae085ec66f320a26a3f0a6c60d7f2b29d by Miss Islington (bot) in branch '3.9': bpo-45187: Fix dangling threads in test_socket.CreateServerFunctionalTest (GH-28422) (GH-28424)

[issue45187] Some tests in test_socket are not run

miss-islington added the comment: New changeset 21711d53411e0da5976a9af591cd6ca97033f712 by Miss Islington (bot) in branch '3.10': bpo-45187: Fix dangling threads in test_socket.CreateServerFunctionalTest (GH-28422)

[issue45187] Some tests in test_socket are not run

Change by miss-islington : -- pull_requests: +26836 pull_request: https://github.com/python/cpython/pull/28424 ___ Python tracker ___

[issue45187] Some tests in test_socket are not run

Change by miss-islington : -- pull_requests: +26835 pull_request: https://github.com/python/cpython/pull/28423 ___ Python tracker ___

[issue45187] Some tests in test_socket are not run

Serhiy Storchaka added the comment: New changeset 51ebb7f4f5e9bdcf8279a1d91be9569706f6bead by Serhiy Storchaka in branch 'main': bpo-45187: Fix dangling threads in test_socket.CreateServerFunctionalTest (GH-28422)

[issue45187] Some tests in test_socket are not run

Change by Serhiy Storchaka : -- pull_requests: +26834 pull_request: https://github.com/python/cpython/pull/28422 ___ Python tracker ___

[issue45187] Some tests in test_socket are not run

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45187] Some tests in test_socket are not run

Serhiy Storchaka added the comment: New changeset 0f4449ecb0d678984b1343d60c070dcb1bd62e56 by Łukasz Langa in branch '3.9': [3.9] bpo-45187: Collect test_socket tests using unittest (GH-28317) (GH-28413) https://github.com/python/cpython/commit/0f4449ecb0d678984b1343d60c070dcb1bd62e56

[issue45187] Some tests in test_socket are not run

miss-islington added the comment: New changeset 5a5684a14b1417fea27af6b6a89eb7faec7fb80a by Miss Islington (bot) in branch '3.10': bpo-45187: Collect test_socket tests using unittest (GH-28317) https://github.com/python/cpython/commit/5a5684a14b1417fea27af6b6a89eb7faec7fb80a --

[issue45187] Some tests in test_socket are not run

Change by Łukasz Langa : -- pull_requests: +26825 pull_request: https://github.com/python/cpython/pull/28413 ___ Python tracker ___

[issue45187] Some tests in test_socket are not run

Łukasz Langa added the comment: New changeset 0361335b80b435ca3694981b41f8269e390eb892 by Serhiy Storchaka in branch 'main': bpo-45187: Collect test_socket tests using unittest (GH-28317) https://github.com/python/cpython/commit/0361335b80b435ca3694981b41f8269e390eb892 -- nosy:

[issue45187] Some tests in test_socket are not run

Change by miss-islington : -- nosy: +miss-islington nosy_count: 2.0 -> 3.0 pull_requests: +26824 pull_request: https://github.com/python/cpython/pull/28412 ___ Python tracker

[issue45187] Some tests in test_socket are not run

Serhiy Storchaka added the comment: Running omitted tests exposed some real bugs. See issue45212, issue45228. -- ___ Python tracker ___

[issue45187] Some tests in test_socket are not run

Change by Serhiy Storchaka : -- dependencies: +Stack buffer overflow in parsing J1939 network address ___ Python tracker ___ ___

[issue45187] Some tests in test_socket are not run

Change by Serhiy Storchaka : -- dependencies: +Dangling threads in skipped tests in test_socket ___ Python tracker ___ ___

[issue45187] Some tests in test_socket are not run

Serhiy Storchaka added the comment: PR 28317 makes test classes in test_socket be autocollected instead of explicitly enumerated. This will save as from similar errors in future. -- ___ Python tracker

[issue45187] Some tests in test_socket are not run

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +26727 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28317 ___ Python tracker

[issue45187] Some tests in test_socket are not run

New submission from Serhiy Storchaka : Test classes ISOTPTest, J1939Test, BasicUDPLITETest, UDPLITETimeoutTest in test_socket are not included in the list of test classes and are not run by regrtest. -- components: Tests messages: 401725 nosy: serhiy.storchaka priority: normal