[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Larry Hastings added the comment: I only did my experiments with the _wrappers.c Christian gave me. If that's not the shipping version of wrapt, and wrapt doesn't exhibit this behavior in 3.10, then that's good. I agree you can wait to address this behavior until it affects code you

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Graham Dumpleton added the comment: Let me try and summarise what I do understand about this. The existing wrapt code as written and its tests, work fine for Python 2.7 and 3.6-3.11. No special case handling is done in tests related to checking annotations that I can remember. The only

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Larry Hastings added the comment: Graham: I'm happy to help. I can write a more elaborate explanation of what's happening, or answer questions, whatever you like. I'm a fan of wrapt so I'd certainly like to see this issue resolved. And, seeing as you're the author and maintainer of wrapt,

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Graham Dumpleton added the comment: I don't know about the comment "he has far more experience than I do with this sort of object proxying wizardry". I read what you said and my brain melted. I am getting too old for this and trying to understand how anything works anymore takes me ages.

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Larry Hastings added the comment: (It's also possible your workaround where wrapt explicitly defines an "__annotations__" getset on every child of ObjectProxy is the right fix. I don't know; I don't know the fine points of attribute access, like when does it access getsets on the type, vs

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Larry Hastings added the comment: This isn't a CPython bug. It's a change in CPython behavior that wrapt needs to accommodate. In particular, it isn't 'causing a regression for C subclasses of heap types when the parent class has an "__annotations__" descriptor', nor do child classes have

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Christian Heimes added the comment: I created a new branch in my clone for you that has the 3.10 workaround disabled. # checkout: git clone -b bpo45319 https://github.com/tiran/wrapt.git cd wrapt # build src/wrapt/_wrappers.abi3.so python3 setup.py build_ext -i # run tests $ PYTHONPATH=src

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Larry Hastings added the comment: (Preferably not using "tox". I don't know that tool.) -- ___ Python tracker ___ ___

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Larry Hastings added the comment: I got the PR locally, but the command-line you gave me fails, tox can't find python3.10 despite it being on the path. Rather than force me to reverse-engineer and recreate your build environment, can you give me a straightforward command-line or shell

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Larry Hastings added the comment: I finally have some bandwidth to look at this--sorry for being a bit slow. I wasn't able to reproduce, because the patch didn't apply cleanly. I downloaded the patch ( https://patch-diff.githubusercontent.com/raw/GrahamDumpleton/wrapt/pull/187.patch ) and

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Christian Heimes added the comment: Larry, could you please take a look? Your commit is causing a regression for C subclasses of heap types when the parent class has an "__annotations__" descriptor. The child class no longer uses the descriptor of the parent class. -- nosy: +larry

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Pablo Galindo Salgado added the comment: Ah, that is likely because type_getsets now gets directly an __annotations__ field. -- ___ Python tracker ___

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Christian Heimes added the comment: The culprit is commit 2f2b69855d6524e15d12c15ddc0adce629e7de84 for bpo-43901: Lazy-create an empty annotations dict in all unannotated user classes and modules (GH-25623). -- ___ Python tracker

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Christian Heimes added the comment: I'm bisecting now. -- nosy: +petr.viktorin, vstinner ___ Python tracker ___ ___

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Pablo Galindo Salgado added the comment: If you want a potential fix to be included in 3.10.0 it must be commited in the next 24/48 hours, otherwise it will need to wait for 3.10.1 -- nosy: -petr.viktorin, vstinner ___ Python tracker

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Change by STINNER Victor : -- nosy: +petr.viktorin, vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Pablo Galindo Salgado added the comment: Christian, could you bisect using your reproducer? -- ___ Python tracker ___ ___

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

Change by Graham Dumpleton : -- nosy: +grahamd ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45319] Possible regression in __annotations__ descr for heap type subclasses

New submission from Christian Heimes : While I was working on a patch to port wrapt to limited API and stable ABI, I noticed a possible regression in __annotations__ PyGetSetDef. It looks like C heap type subclasses no longer inherit the __annotations__ descriptor from a C heap type parent