[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Eric Snow added the comment: This is done now. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Eric Snow added the comment: New changeset 074fa5750640a067d9894c69378a00ceecc3b948 by Eric Snow in branch 'main': bpo-45395: Make custom frozen modules additions instead of replacements. (gh-28778) https://github.com/python/cpython/commit/074fa5750640a067d9894c69378a00ceecc3b948

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Marc-Andre Lemburg added the comment: On 26.10.2021 16:02, Eric Snow wrote: > > FYI, I figured out the problem on my end. I wasn't using an installed > python. Once I did it worked fine. Oh, you mean you tried using it directly from the source tree ? I don't think I ever tried that direct

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Eric Snow added the comment: FYI, I figured out the problem on my end. I wasn't using an installed python. Once I did it worked fine. -- ___ Python tracker ___

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Marc-Andre Lemburg added the comment: I have an initial version of PyRun for Python 3.10 running as well. This created a few more headaches in order to make it work with setuptools and some glitches which appear to be bugs in 3.10 (https://bugs.python.org/issue45563 and

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Eric Snow added the comment: On Wed, Oct 20, 2021 at 8:38 AM Marc-Andre Lemburg wrote: > Yes, 3.10 is next, once I have 3.9 ironed out. And then I'll give 3.11 a try. Thanks! > Sorry, I wasn't clear. PGO is not a problem for test_embed. I just > wonder why the test_embed tests are run for

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Marc-Andre Lemburg added the comment: On 20.10.2021 16:25, Eric Snow wrote: > > Eric Snow added the comment: > > On Wed, Oct 20, 2021 at 6:01 AM Marc-Andre Lemburg > wrote: >> I have PyRun mostly working with Python 3.9. >> ... >> No changes were necessary to Tools/freeze/. > > Great!

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Eric Snow added the comment: On Wed, Oct 20, 2021 at 6:01 AM Marc-Andre Lemburg wrote: > I have PyRun mostly working with Python 3.9. > ... > No changes were necessary to Tools/freeze/. Great! Thanks for getting to that so quickly. Are you going to take a look at 3.10 after you're happy

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Marc-Andre Lemburg added the comment: On 19.10.2021 18:47, Marc-Andre Lemburg wrote: > >> On Sat, Oct 16, 2021 at 5:01 AM Marc-Andre Lemburg >> wrote: >>> I can try to port PyRun to 3.9 and 3.10 to see whether I run into any >>> issues. >>> Would that help ? >> >> Yeah, that would totally

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Eric Snow added the comment: On Tue, Oct 19, 2021 at 10:47 AM Marc-Andre Lemburg wrote: > Ok, I'll start looking into this and post updates here. Thanks! -- ___ Python tracker

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Marc-Andre Lemburg added the comment: On 16.10.2021 21:20, Eric Snow wrote: > > On Sat, Oct 16, 2021 at 5:01 AM Marc-Andre Lemburg > wrote: >> I can try to port PyRun to 3.9 and 3.10 to see whether I run into any issues. >> Would that help ? > > Yeah, that would totally help. Ok, I'll

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Eric Snow added the comment: On Sat, Oct 16, 2021 at 5:01 AM Marc-Andre Lemburg wrote: > I can try to port PyRun to 3.9 and 3.10 to see whether I run into any issues. > Would that help ? Yeah, that would totally help. -- ___ Python tracker

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Marc-Andre Lemburg added the comment: On 16.10.2021 01:31, Eric Snow wrote: > > @MAL, who's maintaining Tools/freeze? I'm not aware of who's using it (other > than you, of course). It looks like PyRun isn't compatible with anything > newer than 3.5, so it seems like that isn't verifying

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Eric Snow added the comment: @MAL, who's maintaining Tools/freeze? I'm not aware of who's using it (other than you, of course). It looks like PyRun isn't compatible with anything newer than 3.5, so it seems like that isn't verifying that Tools/freeze still works. Neither does it have

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Marc-Andre Lemburg added the comment: On 14.10.2021 22:56, Eric Snow wrote: > > @MAL, what's the best way to make sure Tools/freeze is still working? I > don't see any tests for it in the test suite. I tried running the test in > Tools/freeze/test, but I can't get that to work on main (or

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Eric Snow added the comment: @MAL, what's the best way to make sure Tools/freeze is still working? I don't see any tests for it in the test suite. I tried running the test in Tools/freeze/test, but I can't get that to work on main (or on the 3.10 branch). --

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Marc-Andre Lemburg added the comment: On 07.10.2021 16:40, Eric Snow wrote: > > On Thu, Oct 7, 2021 at 1:17 AM Marc-Andre Lemburg > wrote: >> I'm not sure I follow, but in any case, please make sure that >> the freeze tool in Tools/ continues to work with the new mechanism. >> >> The freeze

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Eric Snow added the comment: On Thu, Oct 7, 2021 at 1:17 AM Marc-Andre Lemburg wrote: > I'm not sure I follow, but in any case, please make sure that > the freeze tool in Tools/ continues to work with the new mechanism. > > The freeze tool would also need to know which modules are already >

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Marc-Andre Lemburg added the comment: I'm not sure I follow, but in any case, please make sure that the freeze tool in Tools/ continues to work with the new mechanism. The freeze tool would also need to know which modules are already frozen via the new script, so that modules don't get

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Eric Snow added the comment: I've posted a PR that demonstrates a reasonable solution. -- ___ Python tracker ___ ___

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

Change by Eric Snow : -- keywords: +patch pull_requests: +27112 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/28778 ___ Python tracker

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

New submission from Eric Snow : The mechanism to add custom frozen modules to the Python runtime is to set PyImport_FrozenModules (see Python/frozen.c) to some new array. This means that the default frozen modules (from _PyImport_FrozenModules) are no longer used unless explicitly added to