[issue45431] [C API] Rename CFrame or hide it to only export names starting with Py

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45431] [C API] Rename CFrame or hide it to only export names starting with Py

STINNER Victor added the comment: Ok, CFrame has been renamed. > We should either make the whole PyThreadState structure private (move it to > the internal C API) This idea is tracked by bpo-39947. -- ___ Python tracker

[issue45431] [C API] Rename CFrame or hide it to only export names starting with Py

STINNER Victor added the comment: New changeset 7496f9587306772b56ed074092c020f3ef16bf95 by Victor Stinner in branch 'main': bpo-45431: Rename CFrame to _PyCFrame in the C API (GH-31584) https://github.com/python/cpython/commit/7496f9587306772b56ed074092c020f3ef16bf95 --

[issue45431] [C API] Rename CFrame or hide it to only export names starting with Py

Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45431] [C API] Rename CFrame or hide it to only export names starting with Py

STINNER Victor added the comment: > We should either make the whole PyThreadState structure private (move it to > the internal C API), or rename CFrame (to PyCFrame?). Well, moving PyThreadState to the internal C API is complicate. I prefer to start by renaming CFrame to PyCFrame: see

[issue45431] [C API] Rename CFrame or hide it to only export names starting with Py

Change by STINNER Victor : -- keywords: +patch pull_requests: +29707 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31584 ___ Python tracker ___

[issue45431] [C API] Rename CFrame or hide it to only export names starting with Py

STINNER Victor added the comment: Mark Shannon: > Struct names aren't exported as symbols. Right. > So, I assume that are worried about name clashes for code that has > #include "Python.h". Right :-) > Isn't the threadstate struct supposed to be opaque? Technically, it's public. I'm

[issue45431] [C API] Rename CFrame or hide it to only export names starting with Py

Mark Shannon added the comment: Struct names aren't exported as symbols. $ nm ./python | grep CFrame So, I assume that are worried about name clashes for code that has #include "Python.h". Isn't the threadstate struct supposed to be opaque? If so, then shouldn't it be moved to an internal

[issue45431] [C API] Rename CFrame or hide it to only export names starting with Py

STINNER Victor added the comment: See also the old isssue with "READONLY": bpo-2897 "PyMemberDef missing in limited API / Deprecate structmember.h". -- ___ Python tracker

[issue45431] [C API] Rename CFrame or hide it to only export names starting with Py

STINNER Victor added the comment: See also bpo-45316: [C API] Functions not exported with PyAPI_FUNC(). -- ___ Python tracker ___

[issue45431] [C API] Rename CFrame or hide it to only export names starting with Py

New submission from STINNER Victor : #include should only define names which start with "Py" (Py, _Py, PY, _PY), but it now defines a structure called "CFrame" in Include/cpython/pystate.h. We should either make the whole PyThreadState structure private (move it to the internal C API), or