[issue45474] [C API] marshal.h must not use FILE* type in the limited C API

miss-islington added the comment: New changeset 98fa3b53e2aecc5ecec64a921bc9cf4f9d07ac75 by Petr Viktorin in branch 'main': bpo-45474: Exclude all of marshal.h if Py_LIMITED_API is defined (GH-29061) https://github.com/python/cpython/commit/98fa3b53e2aecc5ecec64a921bc9cf4f9d07ac75

[issue45474] [C API] marshal.h must not use FILE* type in the limited C API

Change by Petr Viktorin : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue45474] [C API] marshal.h must not use FILE* type in the limited C API

Change by Petr Viktorin : -- pull_requests: +27328 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/29061 ___ Python tracker ___

[issue45474] [C API] marshal.h must not use FILE* type in the limited C API

Petr Viktorin added the comment: Nothing from marshal.h is part of the limited API, and nothing from there is exported in the stable ABI DLL. The entire file should be in `#ifndef Py_LIMITED_API`, rather than just a part. -- status: closed -> open

[issue45474] [C API] marshal.h must not use FILE* type in the limited C API

STINNER Victor added the comment: Petr: > Just note that these were *not* part of the limited API, which is defined in > Misc/stable_abi.txt rather than the #ifdefs: > https://docs.python.org/3.10/c-api/stable.html#stable > If they were, the functions would need to remain in the stable ABI.

[issue45474] [C API] marshal.h must not use FILE* type in the limited C API

Petr Viktorin added the comment: Just note that these were *not* part of the limited API, which is defined in Misc/stable_abi.txt rather than the #ifdefs: https://docs.python.org/3.10/c-api/stable.html#stable If they were, the functions would need to remain in the stable ABI. --

[issue45474] [C API] marshal.h must not use FILE* type in the limited C API

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45474] [C API] marshal.h must not use FILE* type in the limited C API

STINNER Victor added the comment: New changeset af1083e975b9627a5c97013d3a2b9aef0e4b333c by Victor Stinner in branch 'main': bpo-45474: Fix the limited C API of marshal.h (GH-28956) https://github.com/python/cpython/commit/af1083e975b9627a5c97013d3a2b9aef0e4b333c --

[issue45474] [C API] marshal.h must not use FILE* type in the limited C API

Change by STINNER Victor : -- keywords: +patch pull_requests: +27245 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28956 ___ Python tracker ___

[issue45474] [C API] marshal.h must not use FILE* type in the limited C API

New submission from STINNER Victor : Include/marshal.h defines 2 functions with FILE* argument in the limited C API, whereas the PEP 384 disallows that: "In addition, functions expecting FILE* are not part of the ABI, to avoid depending on a specific version of the Microsoft C runtime DLL on