[issue45798] Move _decimal build setup into configure

Ned Deily added the comment: The issue here turned out to be that the architecture selection code for libmpdec builds on macOS had been scrambled a bit on the move from setup.py to configure. To support universal builds correctly, libmpdec has code to decide itself which arch(s) to build

[issue45798] Move _decimal build setup into configure

Ned Deily added the comment: New changeset ddbab69b6d44085564a9b5022b96b002a52b2f2b by Ned Deily in branch 'main': bpo-45798: Let libmpdec decide which archs to build on macOS as done previously. (GH-29949) https://github.com/python/cpython/commit/ddbab69b6d44085564a9b5022b96b002a52b2f2b

[issue45798] Move _decimal build setup into configure

Change by Ned Deily : -- pull_requests: +28174 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29949 ___ Python tracker ___

[issue45798] Move _decimal build setup into configure

Ned Deily added the comment: It looks like this change broke macOS universal2 builds of libmpdec. I'm looking at it now but wanted to flag it as a "release blocker" for tagging 3.11.0a3. -- nosy: +ned.deily priority: normal -> release blocker resolution: fixed -> stage: resolved ->

[issue45798] Move _decimal build setup into configure

Change by Christian Heimes : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45798] Move _decimal build setup into configure

Christian Heimes added the comment: I tested the --with-system-libmpdec successfully on my system. Most vendors are using the internal copy of libmpdec any way. AFAIK only Debian-based systems use their own system libmpdec. $ ./configure -C --with-system-libmpdec $ make ... building

[issue45798] Move _decimal build setup into configure

Christian Heimes added the comment: Thanks for the quick review, Mark! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue45798] Move _decimal build setup into configure

Christian Heimes added the comment: New changeset 0486570f7b2b5a75812e5a01a8dca58bfadc2437 by Christian Heimes in branch 'main': bpo-45798: Move _decimal build setup into configure (GH-29541) https://github.com/python/cpython/commit/0486570f7b2b5a75812e5a01a8dca58bfadc2437 --

[issue45798] Move _decimal build setup into configure

Christian Heimes added the comment: PS: I had to add an explicit make rule for each object file. "%.o: %c" templates are not portable. -- ___ Python tracker ___

[issue45798] Move _decimal build setup into configure

Change by Christian Heimes : -- keywords: +patch pull_requests: +27793 pull_request: https://github.com/python/cpython/pull/29541 ___ Python tracker ___

[issue45798] Move _decimal build setup into configure

New submission from Christian Heimes : Compiler and linker flags for _decimal and internal libmpdec are currently handled by a mix of configure checks and if/else chains in setup.py. The split makes it harder to build _decimal correctly from Modules/Setup. The Modules/Setup file also does