[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

Carl Friedrich Bolz-Tereick added the comment: Oh, don't worry, it's all good! It got fixed and I learned something. -- ___ Python tracker ___

[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

Pablo Galindo Salgado added the comment: New changeset 438817fdd5b731d486285d205bed2e78b655c0d6 by Miss Islington (bot) in branch '3.10': bpo-46042: Improve SyntaxError locations in the symbol table (GH-30059) (GH-30064)

[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

Pablo Galindo Salgado added the comment: > Oh no, I was about to open mine ;-) Sorry, Carl, I apologize. I hope it was not too disruptive to do the work. I was taking a look and I felt bad that the issue was probably messier than I thought and I didn't want you to have to iterate many times

[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +28284 pull_request: https://github.com/python/cpython/pull/30064 ___ Python tracker

[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

Pablo Galindo Salgado added the comment: New changeset 59435eea08d30796174552c0ca03c59b41adf8a5 by Pablo Galindo Salgado in branch 'main': bpo-46042: Improve SyntaxError locations in the symbol table (GH-30059) https://github.com/python/cpython/commit/59435eea08d30796174552c0ca03c59b41adf8a5

[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

Carl Friedrich Bolz-Tereick added the comment: ah, confused, seems you fixed them both too. will take a closer look! -- ___ Python tracker ___

[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

Carl Friedrich Bolz-Tereick added the comment: Oh no, I was about to open mine ;-) https://github.com/python/cpython/compare/main...cfbolz:bpo-46042-syntax-error-range-duplicate-argument?expand=1 Basically equivalent, but I fixed the second bug too (would be very easy to add to yours)

[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

Pablo Galindo Salgado added the comment: Don't worry, turns out it was a bit messier than I thought, so I prepared the PR. If you have some time, it would be great if you can take a quick look. -- ___ Python tracker

[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +28279 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30059 ___ Python tracker

[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

Carl Friedrich Bolz-Tereick added the comment: let's see whether I promised too much, I don't know CPython's symtable.c too well yet ;-). Will shout for help when I get stuck. Anyway, here is a related bug, coming from the same symtable function symtable_add_def_helper, also with an

[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

Pablo Galindo Salgado added the comment: Thanks for the catch Carl! > I can try to fix this. Awesome, I will wait for the PR! -- ___ Python tracker ___

[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

Change by Andre Roberge : -- nosy: +aroberge ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

New submission from Carl Friedrich Bolz-Tereick : The error range for the "duplicate argument in function definition" SyntaxError is too large: $ cat x.py def f(a, b, c, d, e, f, g, a): pass $ python x.py File "/home/cfbolz/projects/cpython/x.py", line 1 def f(a, b, c, d, e, f, g, a):