[issue46124] Deprecation warning in zoneinfo module

Jason R. Coombs added the comment: Closing, presumed fixed. Please re-open if not. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue46124] Deprecation warning in zoneinfo module

miss-islington added the comment: New changeset 00b2b578bd9e516d601063a086b03177f546bcdd by Jason R. Coombs in branch 'main': bpo-46124: Update zoneinfo to rely on importlib.resources traversable API. (GH-30190) https://github.com/python/cpython/commit/00b2b578bd9e516d601063a086b03177f546bcd

[issue46124] Deprecation warning in zoneinfo module

Jason R. Coombs added the comment: Normalize_path from legacy implementation: https://github.com/python/importlib_resources/blob/3beb2fd5831e65f7b45033e1ec276c4a6b4ca973/importlib_resources/_legacy.py#L30-L40 -- ___ Python tracker

[issue46124] Deprecation warning in zoneinfo module

Jason R. Coombs added the comment: > Does `joinpath` have less validation? Yes. Previously, resources.* would perform some validation on the path to ensure that it didn't contain path separators (to avoid users attempting to get resources in subdirectories or perhaps manipulating the path in

[issue46124] Deprecation warning in zoneinfo module

Karthikeyan Singaravelan added the comment: I just copied the implementation and normalize_path function was part of it. Looking into the implementation of normalize_path it validates the given argument to be a filename without any separator. I will leave it to Jason for a better understandi

[issue46124] Deprecation warning in zoneinfo module

Paul Ganssle added the comment: Jason's patch looks good to me, but I don't understand why Karthikeyan originally suggested using `normalize_path`. Trying to dig through exactly how `files().joinpath().open` is implemented has so many layers of indirection and abstract classes that I can't q

[issue46124] Deprecation warning in zoneinfo module

Change by Jason R. Coombs : -- assignee: jaraco -> p-ganssle ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46124] Deprecation warning in zoneinfo module

Change by Jason R. Coombs : -- keywords: +patch pull_requests: +28410 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30190 ___ Python tracker ___

[issue46124] Deprecation warning in zoneinfo module

Jason R. Coombs added the comment: I filed issue46125 to track that issue separately. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue46124] Deprecation warning in zoneinfo module

Jason R. Coombs added the comment: I just confirmed, and `normalize_path` has been moved to the _legacy module for importlib_resources, so I'd expect that change to land in CPython soon too. -- ___ Python tracker

[issue46124] Deprecation warning in zoneinfo module

Change by Jason R. Coombs : -- assignee: -> jaraco ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue46124] Deprecation warning in zoneinfo module

Jason R. Coombs added the comment: I would hope that normalize_path would not be needed. It might be for drop-in compatibility. If it's needed for zoneinfo, I'd like to consider why and what implications that has for the deprecation of the legacy API. --

[issue46124] Deprecation warning in zoneinfo module

New submission from Karthikeyan Singaravelan : zoneinfo module currently emits deprecation warnings due to API changes in importlib.resources ./python -Wonce -m test test_zoneinfo 0:00:00 load avg: 0.73 Run tests sequentially 0:00:00 load avg: 0.73 [1/1] test_zoneinfo /home/karthikeyan/stuff/p