[issue46246] importlib.metadata.DeprecatedList appears to be missing __slots__

Change by Jason R. Coombs : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue46246] importlib.metadata.DeprecatedList appears to be missing __slots__

miss-islington added the comment: New changeset 1124ab6d1d15dc5058e03b63fd1d95e6f1009cc3 by Miss Islington (bot) in branch '3.10': bpo-46246: add missing __slots__ to importlib.metadata.DeprecatedList (GH-30452)

[issue46246] importlib.metadata.DeprecatedList appears to be missing __slots__

Change by miss-islington : -- pull_requests: +29433 pull_request: https://github.com/python/cpython/pull/31269 ___ Python tracker ___

[issue46246] importlib.metadata.DeprecatedList appears to be missing __slots__

miss-islington added the comment: New changeset dd76b3f7d332dd6eced5cbc2ad2adfc397700b3d by Arie Bovenberg in branch 'main': bpo-46246: add missing __slots__ to importlib.metadata.DeprecatedList (GH-30452) https://github.com/python/cpython/commit/dd76b3f7d332dd6eced5cbc2ad2adfc397700b3d

[issue46246] importlib.metadata.DeprecatedList appears to be missing __slots__

Jason R. Coombs added the comment: I'm pretty sure both EntryPoints and DeprecatedList were introduced in Python 3.10, so 3.9 and 3.8 aren't relevant. -- versions: -Python 3.8, Python 3.9 ___ Python tracker

[issue46246] importlib.metadata.DeprecatedList appears to be missing __slots__

Change by Arie Bovenberg : -- keywords: +patch pull_requests: +28656 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30452 ___ Python tracker ___

[issue46246] importlib.metadata.DeprecatedList appears to be missing __slots__

Jason R. Coombs added the comment: Today I learned something. Thanks Arie. Yes, I agree that's a mistake. Perhaps the test suite should also have a test to capture the missed expectation (that __dict__ should not be present or setting attributes on EntryPoints instances should fail).

[issue46246] importlib.metadata.DeprecatedList appears to be missing __slots__

Arie Bovenberg added the comment: @jaraco thanks for your quick response. In short: __slots__ allows class layout to be optimized by replacing the class __dict__ with specific descriptors. This results in a class where only specific attributes can be get/set. However, you only really get

[issue46246] importlib.metadata.DeprecatedList appears to be missing __slots__

Jason R. Coombs added the comment: Perhaps it is a mistake. The `__slots__` were added as a (possible premature) optimization in [this conversation](https://github.com/python/importlib_metadata/pull/278/files#r565475347). It's not obvious to me what the danger is in defining __slots__ in a

[issue46246] importlib.metadata.DeprecatedList appears to be missing __slots__

Change by Alex Waygood : -- nosy: +jaraco ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46246] importlib.metadata.DeprecatedList appears to be missing __slots__

New submission from Arie Bovenberg : (as instructed in bpo-46244, I've created this ticket) The subclass `EntryPoints` defines __slots__, but its base `DeprecatedList` does not. This appears to be a mistake. If so, I'd like to create a PR to fix it. -- components: Library (Lib)