[issue46333] ForwardRef.__eq__ does not respect module parameter

Change by Jelle Zijlstra : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue46333] ForwardRef.__eq__ does not respect module parameter

miss-islington added the comment: New changeset 29ae7d3996e073ec3f15c4e7486b17c1d0e3c8f5 by Miss Islington (bot) in branch '3.9': bpo-46333: Honor `module` parameter in ForwardRef (GH-30536) https://github.com/python/cpython/commit/29ae7d3996e073ec3f15c4e7486b17c1d0e3c8f5 --

[issue46333] ForwardRef.__eq__ does not respect module parameter

miss-islington added the comment: New changeset a17d59a6df146077b5420b36c35a1b82ab3f071a by Miss Islington (bot) in branch '3.10': [3.10] bpo-46333: Honor `module` parameter in ForwardRef (GH-30536) (GH-31379) https://github.com/python/cpython/commit/a17d59a6df146077b5420b36c35a1b82ab3f071a

[issue46333] ForwardRef.__eq__ does not respect module parameter

Change by miss-islington : -- pull_requests: +29530 pull_request: https://github.com/python/cpython/pull/31380 ___ Python tracker ___

[issue46333] ForwardRef.__eq__ does not respect module parameter

Change by miss-islington : -- nosy: +miss-islington nosy_count: 8.0 -> 9.0 pull_requests: +29529 pull_request: https://github.com/python/cpython/pull/31379 ___ Python tracker

[issue46333] ForwardRef.__eq__ does not respect module parameter

Jelle Zijlstra added the comment: New changeset 6e7b813195f9bd6a2a15c1f00ef2c0180f6c751a by aha79 in branch 'main': bpo-46333: Honor `module` parameter in ForwardRef (GH-30536) https://github.com/python/cpython/commit/6e7b813195f9bd6a2a15c1f00ef2c0180f6c751a --

[issue46333] ForwardRef.__eq__ does not respect module parameter

Guido van Rossum added the comment: New changeset b70690bb37cc4bac695051484734eede0c1f9ada by aha79 in branch 'main': bpo-46333: include `module` in `ForwardRef.__repr__` (#31283) https://github.com/python/cpython/commit/b70690bb37cc4bac695051484734eede0c1f9ada --

[issue46333] ForwardRef.__eq__ does not respect module parameter

Change by Andreas H. : -- pull_requests: +29443 pull_request: https://github.com/python/cpython/pull/31283 ___ Python tracker ___

[issue46333] ForwardRef.__eq__ does not respect module parameter

Change by Alex Waygood : -- nosy: +Jelle Zijlstra, sobolevn ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46333] ForwardRef.__eq__ does not respect module parameter

Andreas H. added the comment: Ah, let me add one point: PEP563 (-> `from __future__ import annotations`) is also not helping. Even with PEP563 enabled, the JSON example Json = Union[ List['Json'], Dict[str, 'Json'], int, float, bool, None ] needs to be written in exact the same way

[issue46333] ForwardRef.__eq__ does not respect module parameter

Andreas H. added the comment: Yeah, sure. The use-case is (de)serialization. Right now I use the library cattr, but there are many others. If you are interested there is related discussion in the cattr board [1]. The original problem is how to define the types for serialization. 1. If

[issue46333] ForwardRef.__eq__ does not respect module parameter

Ken Jin added the comment: @Andreas First of all, thanks for addressing my questions on the PR. I have one more question which I'll post here since it's not entirely related to your PR. ForwardRef isn't meant to be explicitly instantiated by a user [1] (it's a typing internal class), so do

[issue46333] ForwardRef.__eq__ does not respect module parameter

Change by Roundup Robot : -- keywords: +patch nosy: +python-dev nosy_count: 5.0 -> 6.0 pull_requests: +28737 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/30536 ___ Python tracker

[issue46333] ForwardRef.__eq__ does not respect module parameter

Change by Kumar Aditya : -- nosy: +kumaraditya303 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46333] ForwardRef.__eq__ does not respect module parameter

Change by Alex Waygood : -- nosy: +AlexWaygood ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46333] ForwardRef.__eq__ does not respect module parameter

Andreas H. added the comment: I will give it a try. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46333] ForwardRef.__eq__ does not respect module parameter

Guido van Rossum added the comment: Good catch. Do you want to submit a PR? I agree that the repr() could also be better (but please only show other values if they differ from the default). -- versions: +Python 3.11 ___ Python tracker

[issue46333] ForwardRef.__eq__ does not respect module parameter

Change by Guido van Rossum : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46333] ForwardRef.__eq__ does not respect module parameter

New submission from Andreas H. : The __eq__ method of ForwardRef does not take into account the module parameter. However, ForwardRefs with dissimilar module parameters are referring to different types even if they have different name. Thus also the ForwardRef's with same name but