[issue46377] TimedRotatingFileHandler "midnight" misleading when interval > 1

Mike Schiessl added the comment: Yes, enforcing interval == 1 or interval == None (which pulls the TimedRotatingFileHandler class __init__ default value which is also 1) works perfectly with midnight. I do not see any urge on that topic - as I personally now know the issue :D - but I

[issue46377] TimedRotatingFileHandler "midnight" misleading when interval > 1

Change by Irit Katriel : -- type: behavior -> enhancement versions: -Python 3.10, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker ___

[issue46377] TimedRotatingFileHandler "midnight" misleading when interval > 1

Vinay Sajip added the comment: Unfortunately, you can't rely on people always doing "the sensible thing", for any number of good reasons. If a particular set of parameter values didn't cause failure, it is probably used somewhere. Anyway, your problem goes away if interval == 1, right? If

[issue46377] TimedRotatingFileHandler "midnight" misleading when interval > 1

Mike Schiessl added the comment: i've just checked PR and you're right, something with the PR went wrong. Anyway, midnight (at least from the wording) specifies the "atTime". (which should be midnight). Again, if there's (by mistake) an interval bigger than 1 set(which in my mind makes

[issue46377] TimedRotatingFileHandler "midnight" misleading when interval > 1

Vinay Sajip added the comment: Making a change without considering backward compatibility is premature. I've closed the PR as there appears to be something wrong with it - it references hundreds of changed files. Did you look at the 'atTime' keyword parameter of TimedRotatingFileHandler?

[issue46377] TimedRotatingFileHandler "midnight" misleading when interval > 1

Change by Roundup Robot : -- keywords: +patch nosy: +python-dev nosy_count: 2.0 -> 3.0 pull_requests: +28797 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30599 ___ Python tracker

[issue46377] TimedRotatingFileHandler "midnight" misleading when interval > 1

New submission from Mike Schiessl : Using the TimedRotatingFileHandler along with "when='midnight'" and interval > 1, midnight is handled equally to "days" which is a little misleading. Expectation: setting when to 'midnight', the file is rotated every midnight (interval value should be