[issue46387] `test_field_descriptor` in `test_collections` should test all pickle protocols

Raymond Hettinger added the comment: I approved this but the code wasn't wrong. Once an object has demonstrated that it can pickle at all, it is the testing responsibility of the pickle module tests to make sure that new protocols handle the same inputs as the old ones. I went ahead and

[issue46387] `test_field_descriptor` in `test_collections` should test all pickle protocols

Raymond Hettinger added the comment: New changeset 37eab55ac9da6b6361f136a1da15bfcef12ed954 by Nikita Sobolev in branch 'main': bpo-46387: test all pickle protos in `test_field_descriptor` in `test_collections` (GH-30614)

[issue46387] `test_field_descriptor` in `test_collections` should test all pickle protocols

Change by Nikita Sobolev : -- keywords: +patch pull_requests: +28817 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30614 ___ Python tracker ___

[issue46387] `test_field_descriptor` in `test_collections` should test all pickle protocols

Change by Alex Waygood : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46387] `test_field_descriptor` in `test_collections` should test all pickle protocols

New submission from Nikita Sobolev : Right now this test does not test all pickle protocols: https://github.com/python/cpython/blob/d02c5e9b55a8651b7d396ac3f2bdedf1fc1780b5/Lib/test/test_collections.py#L680-L682 But, I guess that it should, like all other tests do. PR is on its way.