[issue46442] testExceptionCleanupNames doesn't test anything?

Eric V. Smith added the comment: Thanks, @yellowdusk1590! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue46442] testExceptionCleanupNames doesn't test anything?

miss-islington added the comment: New changeset e064af564c8580285a76199229864ddfb1e50c0f by Miss Islington (bot) in branch '3.9': bpo-46442: improve and rename testExceptionCleanupNames (GH-30758) https://github.com/python/cpython/commit/e064af564c8580285a76199229864ddfb1e50c0f --

[issue46442] testExceptionCleanupNames doesn't test anything?

miss-islington added the comment: New changeset d4a9e34401d519250d3b3744cd10394069f748c1 by Miss Islington (bot) in branch '3.10': bpo-46442: improve and rename testExceptionCleanupNames (GH-30758) https://github.com/python/cpython/commit/d4a9e34401d519250d3b3744cd10394069f748c1 --

[issue46442] testExceptionCleanupNames doesn't test anything?

Change by miss-islington : -- pull_requests: +28964 pull_request: https://github.com/python/cpython/pull/30779 ___ Python tracker ___

[issue46442] testExceptionCleanupNames doesn't test anything?

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +28963 pull_request: https://github.com/python/cpython/pull/30778 ___ Python tracker

[issue46442] testExceptionCleanupNames doesn't test anything?

Eric V. Smith added the comment: New changeset 82c53229e18f5853c82cb8ab6b9af1925a0e9e58 by Yellow Dusk in branch 'main': bpo-46442: improve and rename testExceptionCleanupNames (GH-30758) https://github.com/python/cpython/commit/82c53229e18f5853c82cb8ab6b9af1925a0e9e58 --

[issue46442] testExceptionCleanupNames doesn't test anything?

Change by Yellow Dusk : -- pull_requests: +28945 pull_request: https://github.com/python/cpython/pull/30758 ___ Python tracker ___

[issue46442] testExceptionCleanupNames doesn't test anything?

Change by Yellow Dusk : -- keywords: +patch pull_requests: +28940 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30753 ___ Python tracker ___

[issue46442] testExceptionCleanupNames doesn't test anything?

Yellow Dusk added the comment: Great point, it's indeed a good thing to test. So I guess the test is just incomplete. -- ___ Python tracker ___

[issue46442] testExceptionCleanupNames doesn't test anything?

Jelle Zijlstra added the comment: Perhaps it's testing that the implicit `del` doesn't blow up if the variable is already deleted. -- nosy: +Jelle Zijlstra ___ Python tracker

[issue46442] testExceptionCleanupNames doesn't test anything?

Change by Nikita Sobolev : -- nosy: +sobolevn ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46442] testExceptionCleanupNames doesn't test anything?

Eric V. Smith added the comment: I don't know for sure, but maybe it's trying to test "del" interacting with the fact that the "as e" part doesn't escape the "except" clause, unlike normal assignments: >>> try: ... raise Exception ... except Exception as e: ... print('exception

[issue46442] testExceptionCleanupNames doesn't test anything?

New submission from Yellow Dusk : testExceptionCleanupNames() is supposed to test that the local variable bound to the exception instance is only visible inside the except block, and tests that by checking whether the name is in locals(), but it actually deletes the name before that, so it