[issue46647] `test_functools` unexpected failures when C `_functoolsmodule` is missing

Nikita Sobolev added the comment: > Or maybe you have other cases to show the functools module will missing > unexpectly? No, I can't think of any :) Your argument about code churn also makes sense. But, if we ever are going to refactor this test module, this is something to remember of.

[issue46647] `test_functools` unexpected failures when C `_functoolsmodule` is missing

Hai Shi added the comment: > _functoolsmodule is a core bootstrap module and defined in > Modules/Setup.bootstrap. It has no external dependencies. There is no reason > and no point to disable the module. +1. > Cristian, in this case - is there a reason to keep `skipUnless(c_functools)`

[issue46647] `test_functools` unexpected failures when C `_functoolsmodule` is missing

Nikita Sobolev added the comment: Cristian, in this case - is there a reason to keep `skipUnless(c_functools)` around? If we are sure that it is always available - then it should be always tested. We either should have: 1. Cleanly defined skips that work (this PR) 2. Unconditional

[issue46647] `test_functools` unexpected failures when C `_functoolsmodule` is missing

Christian Heimes added the comment: _functoolsmodule is a core bootstrap module and defined in Modules/Setup.bootstrap. It has no external dependencies. There is no reason and no point to disable the module. We can safely assume that all modules defined in Modules/Setup.bootstrap are

[issue46647] `test_functools` unexpected failures when C `_functoolsmodule` is missing

Change by Nikita Sobolev : -- keywords: +patch pull_requests: +29318 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31141 ___ Python tracker ___

[issue46647] `test_functools` unexpected failures when C `_functoolsmodule` is missing

New submission from Nikita Sobolev : Reproduction steps: 1. Add to `Setup.local`: ``` *disabled* _functoolsmodule ``` 2. `.configure && make -j`. Then, ensure that this module is not available: ``` » ./python.exe -c 'import _functools' Traceback (most