[issue46781] Tracing: c_return doesn't report the result

2022-03-04 Thread Mark Shannon
Mark Shannon added the comment: This is an API change. I agree that the API is not what it should be, but we can't change it without breaking an unknown amount of 3rd party code that uses it. -- nosy: +Mark.Shannon ___ Python tracker

[issue46781] Tracing: c_return doesn't report the result

2022-02-17 Thread Matthias Urlichs
Matthias Urlichs added the comment: Added a github PR. Unfortunately it breaks the cprofile testcase, which apparently relies on the old argument value (for no good reason IMHO). I don't know how the profiler works internally. If somebody who does could have a look at it and/or its testcase

[issue46781] Tracing: c_return doesn't report the result

2022-02-17 Thread Matthias Urlichs
Change by Matthias Urlichs : -- keywords: +patch pull_requests: +29537 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31393 ___ Python tracker ___

[issue46781] Tracing: c_return doesn't report the result

2022-02-17 Thread Matthias Urlichs
Matthias Urlichs added the comment: Likewise for c_exception, which should report the exception thruple -- and even has an XXX comment reminding us to fix that (ceval.c 4542). -- ___ Python tracker

[issue46781] Tracing: c_return doesn't report the result

2022-02-17 Thread Matthias Urlichs
New submission from Matthias Urlichs : When tracing/profiling, the "return" event reports the value returned by the exiting function. However, this does not work for C functions. The profiler's "c_return" hook is called with the same C function object as "c_call". This unnecessarily complica