[issue4856] Remove checks for win NT

Hirokazu Yamamoto added the comment: Thanks, committed in r73675(trunk) and r73676(py3k). -- status: open -> closed ___ Python tracker ___ ___

[issue4856] Remove checks for win NT

Amaury Forgeot d'Arc added the comment: Yes, that's what I had in mind. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue4856] Remove checks for win NT

Hirokazu Yamamoto added the comment: Oops, sorry. This function is not needed if GetFileAttributesEx never fail with ERROR_CALL_NOT_IMPLEMENTED. I believe this won't happen on win NT. How about this patch? -- Added file: http://bugs.python.org/file14381/remove_unused_function.patch ___

[issue4856] Remove checks for win NT

Amaury Forgeot d'Arc added the comment: The functions Py_GetFileAttributesExA and Py_GetFileAttributesExW were not removed. Is it intended? -- assignee: -> ocean-city status: closed -> open ___ Python tracker

[issue4856] Remove checks for win NT

Hirokazu Yamamoto added the comment: Thanks, committed in r73603(trunk) and r73604(py3k). -- resolution: -> fixed status: open -> closed ___ Python tracker ___ _

[issue4856] Remove checks for win NT

Martin v. Löwis added the comment: Sure, go ahead. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue4856] Remove checks for win NT

Hirokazu Yamamoto added the comment: OK, 3.1 was out. Can I commit this to trunk and merge it to py3k? -- versions: +Python 3.2 ___ Python tracker ___ ___

[issue4856] Remove checks for win NT

Martin v. Löwis added the comment: I think it's easier if the patch just sits here for six more days; 3.1 won't take much longer. -- ___ Python tracker ___ __

[issue4856] Remove checks for win NT

Hirokazu Yamamoto added the comment: Here is an updated patch with Py_GetFileAttributesEx[AW] removal. I propose to commit this to trunk, and merge it to py3k after 3.1 will be released. -- Added file: http://bugs.python.org/file14327/remove_w9x_code.patch _

[issue4856] Remove checks for win NT

Martin v. Löwis added the comment: The patch is slightly out of date; if updated, it is fine to apply after 3.1. I think Py_GetFileAttributesExA can also be removed. -- ___ Python tracker _

[issue4856] Remove checks for win NT

Changes by Hirokazu Yamamoto : -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue4856] Remove checks for win NT

Hirokazu Yamamoto added the comment: +1. I've tested this patch on win2k & vc6, and worked correctly. -- nosy: +ocean-city ___ Python tracker ___

[issue4856] Remove checks for win NT

Ulrich Eckhardt added the comment: This patch removes all calls to win32's GetVersion() where they are used to detect NT. In posixmodule.c it was used by a wrapper function that cached the result, which then also became obsolete. -- keywords: +patch Added file: http://bugs.python.org/f

[issue4856] Remove checks for win NT

Amaury Forgeot d'Arc added the comment: +1 -- nosy: +amaury.forgeotdarc ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue4856] Remove checks for win NT

New submission from Ulrich Eckhardt : There are several checks like "GetVersion() < 0x8000" that try to determine whether there is support for the WCHAR versions of the win32 API. Since all support for MS Windows 95, 98 and ME has been dropped, all supported systems support those APIs. Als