Martin Panter added the comment:
Opened Issue 23377 for the problem of dropping extra buffered data at the end
of a response.
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4879
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Gregory, please revert your change (74463).
There is no extra data after the response, since such data can only
be generated as a result of a new request.
Your change has disabled the HTTP/1.1 keepalive capability, causing
test
Gregory P. Smith g...@krypto.org added the comment:
Already reverted in
r74522 | gregory.p.smith | 2009-08-18 22:33:48 -0700 (Tue, 18 Aug 2009)
for that reason.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4879
R. David Murray rdmur...@bitdance.com added the comment:
And that update causes failures in test_xmlrpc.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4879
___
Changes by R. David Murray rdmur...@bitdance.com:
--
priority: - normal
stage: - commit review
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4879
___
R. David Murray rdmur...@bitdance.com added the comment:
I think I'll open a new ticket instead.
--
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4879
Gregory P. Smith g...@krypto.org added the comment:
I believe there will be a problem with the patch committed in r68532.
If getresponse(buffering=True) is called, extra data on the socket may
be consumed by the socket.makefile() buffer which will cause problems if
the connection is not closed
Gregory P. Smith g...@krypto.org added the comment:
trunk r74463 now forces the HTTPResponse to close afterwards when
buffering=True to avoid the issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4879
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
The socket.socket.makefile() now returns a quite different kind of
object, namely a SocketIO thing. This comes as a result of the IO
refactoring in 3.0.
The good side to this is that old and naughty apps have been forbidden
to
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
I'm afraid I misunderstood the problem.
Yes, since u.fp is now a io.BufferedReader() rather than a socket.Socket
(), the _sock member has moved.
But looking at the other assertions in test_urllib2net.py, you can see
the different
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Checked in r69209 to py3k
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4879
___
___
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
This causes failures in test_urllib2net.
The fix is easy: a handful of
-self.assertTrue(u.fp._sock.gettimeout() is None)
+self.assertTrue(u.fp.raw._sock.gettimeout() is None)
But doesn't this show a
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Adding crossref to http://bugs.python.org/issue4448 regarding the
porting of this feature to 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4879
Benjamin Peterson benja...@python.org added the comment:
Kristján, could you merge this change into the Py3k branch, please?
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4879
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Yes, if you think so. But my intention was to indicate that
the nobuffering is a special feature the user can turn off to resort
to what could be considered normal, buffered, behaviour.
But either way is fine, and I'll be happy
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Checked in as revision: 68532
--
resolution: - accepted
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4879
Antoine Pitrou pit...@free.fr added the comment:
Why not name the parameter buffering=False rather than nobuffer=True?
Sounds more natural to me.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4879
Changes by Kristján Valur Jónsson krist...@ccpgames.com:
--
title: Allo buffering for HTTPResponse - Allow buffering for HTTPResponse
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4879
___
18 matches
Mail list logo
