[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Serhiy Storchaka added the comment: posix_putenv_garbage no longer used on Windows. -- resolution: -> fixed stage: patch review -> resolved status: pending -> closed ___ Python tracker

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Serhiy Storchaka added the comment: The original issues seem fixed. As for leaks in posix_putenv_garbage on Windows, it is better to open a new issue for this. -- status: open -> pending ___ Python tracker

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Serhiy Storchaka added the comment: The part of this issue ('=' in putenv()) is fixed in issue30746. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by Serhiy Storchaka : -- pull_requests: +2432 ___ Python tracker ___ ___

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by Peter Funk : -- nosy: +pefu ___ Python tracker ___ ___ Python-bugs-list

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: -BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4926 ___ ___

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Mark Lawrence breamore...@yahoo.co.uk added the comment: @David: I couldn't apply the patches directly with tortoisesvn cos of the git format so tried to do them manually but failed. E.g. in test_os I couldn't find PYTHONTESTVAROS to insert the two new lines after and in test_posix couldn't

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

David Watson bai...@users.sourceforge.net added the comment: You're having a bad day at the office :) Just use patch -p1. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4926 ___

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

David Watson bai...@users.sourceforge.net added the comment: Unit tests were in the patch! However, none of the patches applied any more, so I've updated them and also improved the tests a bit. Again, I haven't tried them on Windows. Unsetting a nonexistent variable isn't supposed to be an

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by David Watson bai...@users.sourceforge.net: Added file: http://bugs.python.org/file18186/putenv-empty-2.x.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4926 ___

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by David Watson bai...@users.sourceforge.net: Added file: http://bugs.python.org/file18187/putenv-equals-3.x.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4926 ___

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by David Watson bai...@users.sourceforge.net: Added file: http://bugs.python.org/file18188/putenv-empty-3.x.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4926 ___

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by David Watson bai...@users.sourceforge.net: Added file: http://bugs.python.org/file18189/visibility-2.x.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4926 ___

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by David Watson bai...@users.sourceforge.net: Added file: http://bugs.python.org/file18190/visibility-3.x.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4926 ___

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Amaury Forgeot d'Arc amaur...@gmail.com added the comment: The patch actually does 2 things: - it prevents the usage of '=' in putenv, which is is good because the putenv() system call handles this badly. - it will raise an error when unsetting a nonexistent variable. This is a change in

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Mark Lawrence breamore...@yahoo.co.uk added the comment: As patches were originally provided would someone kindly review them. -- nosy: +BreamoreBoy, loewis stage: - patch review versions: +Python 2.7, Python 3.1, Python 3.2 ___ Python tracker

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

New submission from David Watson bai...@users.sourceforge.net: One of these problems interacts with the other, and can cause os.unsetenv() to free memory that's still in use. Firstly, calling os.putenv(FOO=BAR, value) causes putenv(3) to be called with the string FOO=BAR=value, which sets a

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by David Watson bai...@users.sourceforge.net: Added file: http://bugs.python.org/file12709/2.x.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4926 ___

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by David Watson bai...@users.sourceforge.net: Added file: http://bugs.python.org/file12710/3.x.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4926 ___

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by Gabriel Genellina gagsl-...@yahoo.com.ar: -- nosy: +gagenellina ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4926 ___ ___