[issue4946] Lib/test/test__locale uses is to compare strings

2009-01-15 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: Fixed in r68628. -- nosy: +benjamin.peterson resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4946

[issue4946] Lib/test/test__locale uses is to compare strings

2009-01-14 Thread Maciek Fijalkowski
New submission from Maciek Fijalkowski fi...@genesilico.pl: this is at least a bad practice. It also might break silently at any point. -- components: Library (Lib), Tests files: out.diff keywords: patch messages: 79846 nosy: fijal severity: normal status: open title:

[issue4946] Lib/test/test__locale uses is to compare strings

2009-01-14 Thread Gabriel Genellina
Gabriel Genellina gagsl-...@yahoo.com.ar added the comment: Yes, checking object identity is wrong in this case. Your patch looks fine to me. I've found several other is comparisons that should not be there -- working on a patch right now. -- nosy: +gagenellina